You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/10 15:53:00 UTC

[PR] [ISSUE #1419] Validate fields used in Prometheus alert rules [rocketmq-dashboard]

yyqdbngt opened a new pull request, #1498:
URL: https://github.com/apache/rocketmq-dashboard/pull/1498

   ## Summary
   - whitelist Prometheus comparison operators
   - validate metric names and alert durations before YAML generation
   - fall back to safe defaults for malformed persisted rules
   - add regression coverage for injected PromQL fragments
   
   ## Testing
   - `mvn -Dtest=AlertServiceTest -Dmaven.compiler.proc=full test`
   
   Closes #1419


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #1419] Validate fields used in Prometheus alert rules [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1498: [ISSUE #1419] Validate fields used in Prometheus alert rules
URL: https://github.com/apache/rocketmq-dashboard/pull/1498


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #1419] Validate fields used in Prometheus alert rules [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #1498:
URL: https://github.com/apache/rocketmq-dashboard/pull/1498#issuecomment-5243789708

   ⚠️ **Merge conflict detected**
   
   This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
   
   ```bash
   git fetch origin
   git checkout btlqql/validate-prometheus-alert-fields
   git rebase origin/develop
   # resolve conflicts, then:
   git push --force-with-lease
   ```
   
   This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
   
   ---
   *Automated notification by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #1419] Validate fields used in Prometheus alert rules [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1498:
URL: https://github.com/apache/rocketmq-dashboard/pull/1498#issuecomment-5251636536

   Closing: the metric/operator/duration validation is fully covered by be5265a8 (identical validateMetric/validateOperator semantics, same constants and fallbacks). The regression test will be brought in separately. Issue #1419 is fixed on trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org