[GitHub] mlegenhausen edited a comment on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

[GitBox <gi...@apache.org>]

mlegenhausen edited a comment on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421369394
 
 
   The Xcode 10 GM is avaibable.
   
   The provided pull request does not work with the GM release, but I found another solution. You can disable the modern buildsystem with `xcodebuild -UseModernBuildSystem=NO ...`.
   
   After you added the switch get another error that "your project path" is not a valid command. It seems that in the case of `archive` it is not possible anymore to supply the project folder as last parameter. So I needed to make `-workspace` and `-archivePath` an absolute path. The `options` for the `isDevice` case need to be changed to
   
   ```js
   options = [
       '-UseModernBuildSystem=NO',
       '-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-' + configuration.toLowerCase() + '.xcconfig'),
       '-workspace', customArgs.workspace || path.join(projectPath, projectName + '.xcworkspace'),
       '-scheme', customArgs.scheme || projectName,
       '-configuration', customArgs.configuration || configuration,
       '-destination', customArgs.destination || 'generic/platform=iOS',
       '-archivePath', customArgs.archivePath || path.join(projectPath, projectName + '.xcarchive')
   ];
   ```
   
   Finally you need to remove the `projectPath` parameter from `spawn('xcodebuild', xcodebuildArgs)`.
   
   Are you planing to which with `cordova-ios` to the new build systems? If not I can provide my fix as pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org