You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2026/04/06 16:15:24 UTC
[PR] Update Agents.md for UI dev [airflow]
bbovenzi opened a new pull request, #64776:
URL: https://github.com/apache/airflow/pull/64776
In reviewing PRs, I noticed some consistent areas where AI tools were making mistakes, including copilot giving bad advice in PR reviews. This should help fix some of them, and reinforce our code standards.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes, Claude Sonnet 4.6
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Agents.md for UI dev [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #64776:
URL: https://github.com/apache/airflow/pull/64776#issuecomment-4194294259
> In the past also I remember there were comments about `useEffect()` - shall this be added here as well?
I linked the previous documentation here so that its included without repeating ourselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Agents.md for UI dev [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #64776:
URL: https://github.com/apache/airflow/pull/64776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Agents.md for UI dev [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #64776:
URL: https://github.com/apache/airflow/pull/64776#discussion_r3040901284
##########
AGENTS.md:
##########
@@ -96,6 +95,23 @@ UV workspace monorepo. Key paths:
- Apache License header on all new files (prek enforces this).
- Newsfragments are only added if a major change or breaking change is applied. This is usually coordinate during review. Please do not add newsfragments per default as in most cases this needs a reversion during review.
+## UI Development (airflow-core/src/airflow/ui)
Review Comment:
This should moved to airflow-core/src/airflow/ui) - like other folder specific AGENTS.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Agents.md for UI dev [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #64776:
URL: https://github.com/apache/airflow/pull/64776#discussion_r3040906472
##########
AGENTS.md:
##########
@@ -96,6 +95,23 @@ UV workspace monorepo. Key paths:
- Apache License header on all new files (prek enforces this).
- Newsfragments are only added if a major change or breaking change is applied. This is usually coordinate during review. Please do not add newsfragments per default as in most cases this needs a reversion during review.
+## UI Development (airflow-core/src/airflow/ui)
Review Comment:
```
./task-sdk/src/airflow/sdk/_shared/AGENTS.md
./providers/common/ai/AGENTS.md
./providers/AGENTS.md
./airflow-core/src/airflow/api_fastapi/execution_api/AGENTS.md
./airflow-core/src/airflow/_shared/AGENTS.md
./.venv/lib/python3.13/site-packages/pydantic_ai/models/AGENTS.md
./.venv/lib/python3.13/site-packages/pydantic_ai/AGENTS.md
./scripts/ci/prek/AGENTS.md
./registry/AGENTS.md
./dev/ide_setup/AGENTS.md
./dev/AGENTS.md
./AGENTS.md
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Agents.md for UI dev [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #64776:
URL: https://github.com/apache/airflow/pull/64776#discussion_r3041081577
##########
AGENTS.md:
##########
@@ -96,6 +95,23 @@ UV workspace monorepo. Key paths:
- Apache License header on all new files (prek enforces this).
- Newsfragments are only added if a major change or breaking change is applied. This is usually coordinate during review. Please do not add newsfragments per default as in most cases this needs a reversion during review.
+## UI Development (airflow-core/src/airflow/ui)
Review Comment:
Good call. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org