You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jeremy Daggett <no...@github.com> on 2014/06/02 18:34:35 UTC
[jclouds] Updates Nova default API to v2 (#390)
This PR updates the `openstack-nova` API default to v2 as described in:
https://issues.apache.org/jira/browse/JCLOUDS-554
- Updated related code and test cases
- Pretty formatted all JSON data
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds nova-v2
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/390
-- Commit Summary --
* JCLOUDS-554: Update Nova default API to v2
-- File Changes --
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/internal/KeystoneFixture.java (4)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseAccessTest.java (18)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/suppliers/LocationIdToURIFromAccessForTypeAndVersionTest.java (16)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/suppliers/RegionIdToAdminURIFromAccessForTypeAndVersionTest.java (2)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/suppliers/RegionIdToURIFromAccessForTypeAndVersionTest.java (8)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/suppliers/ZoneIdToURIFromAccessForTypeAndVersionTest.java (8)
M apis/openstack-keystone/src/test/resources/access_minimal.json (17)
M apis/openstack-keystone/src/test/resources/access_version_uids.json (118)
M apis/openstack-keystone/src/test/resources/adminAuth.json (187)
M apis/openstack-keystone/src/test/resources/admin_extensions.json (12)
M apis/openstack-keystone/src/test/resources/devstackVersion.json (34)
M apis/openstack-keystone/src/test/resources/keystoneAuthResponse.json (28)
M apis/openstack-keystone/src/test/resources/keystoneAuthResponse_openstack.json (80)
M apis/openstack-keystone/src/test/resources/raxAuth.json (253)
M apis/openstack-keystone/src/test/resources/raxVersion.json (47)
M apis/openstack-keystone/src/test/resources/role_create_response.json (7)
M apis/openstack-keystone/src/test/resources/role_list_response.json (15)
M apis/openstack-keystone/src/test/resources/service_create_response.json (9)
M apis/openstack-keystone/src/test/resources/service_list_response.json (17)
M apis/openstack-keystone/src/test/resources/tenant_create_response.json (9)
M apis/openstack-keystone/src/test/resources/tenant_details.json (9)
M apis/openstack-keystone/src/test/resources/tenant_list.json (18)
M apis/openstack-keystone/src/test/resources/tenant_list_att.json (14)
M apis/openstack-keystone/src/test/resources/tenant_update_response.json (9)
M apis/openstack-keystone/src/test/resources/token_details.json (27)
M apis/openstack-keystone/src/test/resources/user_create_response.json (9)
M apis/openstack-keystone/src/test/resources/user_details.json (10)
M apis/openstack-keystone/src/test/resources/user_endpoints.json (22)
M apis/openstack-keystone/src/test/resources/user_list.json (33)
M apis/openstack-keystone/src/test/resources/user_role_list.json (9)
M apis/openstack-keystone/src/test/resources/user_tenant_role_list.json (17)
M apis/openstack-keystone/src/test/resources/user_update_response.json (9)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/NovaApiMetadata.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/AccessKeyAndSecretKeyAndTenantIdAuthenticationExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/AccessKeyAndSecretKeyAndTenantNamePropertyAuthenticationExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/AccessKeyAndSecretKeyAuthenticationExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/PasswordAuthenticationExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/PasswordAuthenticationWithTenantNameExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceAdapterExpectTest.java (16)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/NovaComputeServiceExpectTest.java (28)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaImageExtensionExpectTest.java (8)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaSecurityGroupExtensionExpectTest.java (36)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/functions/AllocateAndAddFloatingIpToNodeExpectTest.java (6)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/functions/ServerInZoneToNodeMetadataTest.java (6)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/AdminActionsApiExpectTest.java (48)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/AvailabilityZoneApiExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FlavorExtraSpecsApiExpectTest.java (16)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPApiExpectTest.java (14)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/HostAdministrationApiExpectTest.java (26)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/HostAggregateApiExpectTest.java (22)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/KeyPairApiExpectTest.java (10)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/QuotaApiExpectTest.java (12)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/SecurityGroupApiExpectTest.java (18)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/ServerWithSecurityGroupsApiExpectTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/SimpleTenantUsageApiExpectTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/VirtualInterfaceApiExpectTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeApiExpectTest.java (56)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeAttachmentApiExpectTest.java (16)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/VolumeTypeApiExpectTest.java (32)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ExtensionApiExpectTest.java (8)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/FlavorApiExpectTest.java (12)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ImageApiExpectTest.java (30)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiExpectTest.java (64)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/functions/CreateSecurityGroupIfNeededTest.java (10)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/functions/FindSecurityGroupWithNameAndReturnTrueExpectTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/handlers/NovaErrorHandlerTest.java (6)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/internal/BaseNovaComputeServiceContextExpectTest.java (10)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/internal/BaseNovaExpectTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseCreateFlavorTest.java (32)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseCreatedServerTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseFlavorListTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseFlavorTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseImageListTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseImageTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerDetailsEssexTest.java (6)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerListTest.java (4)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerTest.java (6)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerWithInternetAddressesTest.java (2)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/PublicIpsInPrivateAddressBlockExpectTest.java (2)
M apis/openstack-nova/src/test/resources/access.json (208)
M apis/openstack-nova/src/test/resources/attachment_details.json (9)
M apis/openstack-nova/src/test/resources/attachment_list.json (11)
M apis/openstack-nova/src/test/resources/extension_details.json (28)
M apis/openstack-nova/src/test/resources/extension_list.json (2)
M apis/openstack-nova/src/test/resources/extension_list_full.json (547)
M apis/openstack-nova/src/test/resources/extension_list_normal.json (65)
M apis/openstack-nova/src/test/resources/extension_list_openstack.json (245)
M apis/openstack-nova/src/test/resources/flavor_details.json (22)
M apis/openstack-nova/src/test/resources/flavor_list.json (6)
M apis/openstack-nova/src/test/resources/flavor_list_detail.json (125)
M apis/openstack-nova/src/test/resources/flavor_list_detail_openstack.json (185)
M apis/openstack-nova/src/test/resources/flavor_new.json (14)
M apis/openstack-nova/src/test/resources/floatingip_details.json (15)
M apis/openstack-nova/src/test/resources/floatingip_list.json (8)
M apis/openstack-nova/src/test/resources/host.json (41)
M apis/openstack-nova/src/test/resources/host_aggregate_details.json (18)
M apis/openstack-nova/src/test/resources/host_aggregate_list.json (20)
M apis/openstack-nova/src/test/resources/host_aggregate_with_host_details.json (20)
M apis/openstack-nova/src/test/resources/hosts_list.json (9)
M apis/openstack-nova/src/test/resources/image_active.json (42)
M apis/openstack-nova/src/test/resources/image_details.json (42)
M apis/openstack-nova/src/test/resources/image_list.json (20)
M apis/openstack-nova/src/test/resources/image_list_detail.json (504)
M apis/openstack-nova/src/test/resources/image_list_detail_imageextension.json (263)
M apis/openstack-nova/src/test/resources/image_list_detail_openstack.json (175)
M apis/openstack-nova/src/test/resources/keypair_created.json (2)
M apis/openstack-nova/src/test/resources/keypair_created_computeservice.json (2)
M apis/openstack-nova/src/test/resources/keypair_list.json (2)
M apis/openstack-nova/src/test/resources/metadata_item.json (4)
M apis/openstack-nova/src/test/resources/metadata_list.json (4)
M apis/openstack-nova/src/test/resources/metadata_updated.json (4)
M apis/openstack-nova/src/test/resources/new_server.json (39)
M apis/openstack-nova/src/test/resources/new_server_disk_config_auto.json (39)
M apis/openstack-nova/src/test/resources/new_server_disk_config_manual.json (39)
M apis/openstack-nova/src/test/resources/new_server_in_zone.json (39)
M apis/openstack-nova/src/test/resources/new_server_networks_response.json (2)
M apis/openstack-nova/src/test/resources/new_server_no_adminpass.json (2)
M apis/openstack-nova/src/test/resources/quotas.json (32)
M apis/openstack-nova/src/test/resources/securitygroup_created.json (4)
M apis/openstack-nova/src/test/resources/securitygroup_details.json (51)
M apis/openstack-nova/src/test/resources/securitygroup_details_computeservice_typical.json (87)
M apis/openstack-nova/src/test/resources/securitygroup_details_extension.json (51)
M apis/openstack-nova/src/test/resources/securitygroup_details_extension_norules.json (17)
M apis/openstack-nova/src/test/resources/securitygroup_details_port22.json (26)
M apis/openstack-nova/src/test/resources/securitygroup_list.json (90)
M apis/openstack-nova/src/test/resources/securitygroup_list_details_computeservice_typical.json (109)
M apis/openstack-nova/src/test/resources/securitygroup_list_extension.json (90)
M apis/openstack-nova/src/test/resources/securitygrouprule_created.json (5)
M apis/openstack-nova/src/test/resources/securitygrouprule_created_cidr.json (2)
M apis/openstack-nova/src/test/resources/securitygrouprule_created_group.json (2)
M apis/openstack-nova/src/test/resources/server_details.json (38)
M apis/openstack-nova/src/test/resources/server_details_devstack.json (104)
M apis/openstack-nova/src/test/resources/server_details_openstack.json (49)
M apis/openstack-nova/src/test/resources/server_diagnostics.json (30)
M apis/openstack-nova/src/test/resources/server_list.json (4)
M apis/openstack-nova/src/test/resources/server_list_details.json (151)
M apis/openstack-nova/src/test/resources/server_list_details_essex.json (334)
M apis/openstack-nova/src/test/resources/server_public_ip_in_private.json (56)
M apis/openstack-nova/src/test/resources/server_with_security_groups.json (63)
M apis/openstack-nova/src/test/resources/server_with_security_groups_extension.json (60)
M apis/openstack-nova/src/test/resources/simple_tenant_usage.json (40)
M apis/openstack-nova/src/test/resources/simple_tenant_usages.json (14)
M apis/openstack-nova/src/test/resources/snapshot_details.json (12)
M apis/openstack-nova/src/test/resources/snapshot_list.json (14)
M apis/openstack-nova/src/test/resources/snapshot_list_detail.json (14)
M apis/openstack-nova/src/test/resources/virtual_interfaces_list.json (9)
M apis/openstack-nova/src/test/resources/volume_details.json (23)
M apis/openstack-nova/src/test/resources/volume_list.json (25)
M apis/openstack-nova/src/test/resources/volume_list_detail.json (25)
M apis/openstack-nova/src/test/resources/volume_type.json (23)
M apis/openstack-nova/src/test/resources/volume_type_extra_specs.json (6)
M apis/openstack-nova/src/test/resources/volume_type_list.json (17)
M providers/hpcloud-compute/src/test/resources/access_hpcloud.json (36)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/390.patch
https://github.com/jclouds/jclouds/pull/390.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by Jeremy Daggett <no...@github.com>.
Closed #390.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#event-143807428
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1475](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1475/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49359674
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1483](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1483/) ABORTED
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49766768
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1003](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1003/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49325228
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1384](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1384/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49323608
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by Jeremy Daggett <no...@github.com>.
Closed #390.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#event-143775282
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1385](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1385/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49357702
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #854](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/854/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-44864338
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1004](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1004/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49358763
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1012](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1012/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49640174
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by Everett Toews <no...@github.com>.
@ccustine Can you give this a review?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-44868147
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by Jeremy Daggett <no...@github.com>.
Reopened #390.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#event-143775289
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by Jeremy Daggett <no...@github.com>.
Merged to master `0d77d8c`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49641024
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by Chris Custine <no...@github.com>.
+1 This looks good to me and it is certainly time to update these defaults. @jdaggett you might have some rebasing/merging issues after the HP Cloud PRs because I also updated some of that json test data.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-47827046
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1474](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1474/) ABORTED
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49407297
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1398](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1398/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-49638952
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by Jeremy Daggett <no...@github.com>.
@ccustine Thanks! The rebase/merge is going to be "fun" indeed! It might take me some time to get through it, but I wanted to make sure that all of your Nova changes were merged prior to this PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-47833467
Re: [jclouds] Updates Nova default API to v2 (#390)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1325](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1325/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/390#issuecomment-44864658