You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by hu...@apache.org on 2022/01/29 12:56:15 UTC
[royale-asjs] branch develop updated: The HTML CheckBox use now a span for the label so we can customize the look with css
This is an automated email from the ASF dual-hosted git repository.
hugoferreira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new bec3d1b The HTML CheckBox use now a span for the label so we can customize the look with css
new aa7ca1c Merge branch 'develop' of https://github.com/apache/royale-asjs into develop
bec3d1b is described below
commit bec3d1baf36cff8776aa19f9ce4e73b94d16801b
Author: Hugo Ferreira <hf...@solidsoft.pt>
AuthorDate: Sat Jan 29 12:56:38 2022 +0000
The HTML CheckBox use now a span for the label so we can customize the look with css
---
.../Basic/src/main/royale/org/apache/royale/html/CheckBox.as | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
index ca18ff0..0bdd673 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
@@ -159,7 +159,7 @@ package org.apache.royale.html
_icon = new CheckBoxIcon();
element.appendChild(_icon.element);
- element.appendChild(document.createTextNode(''));
+ element.appendChild(document.createElement('span'));
//positioner.style.position = 'relative';
_icon.element.royale_wrapper = this;
@@ -170,12 +170,12 @@ package org.apache.royale.html
public function get text():String
{
- return _label.childNodes.item(1).nodeValue;
+ return _label.childNodes.item(1).innerHTML;
}
public function set text(value:String):void
{
- _label.childNodes.item(1).nodeValue = value;
+ _label.childNodes.item(1).innerHTML = value;
}
/**
Re: [royale-asjs] branch develop updated: The HTML CheckBox use now a span for the label so we can customize the look with css
Posted by Hugo Ferreira <hf...@gmail.com>.
Hi,
I didn't know and you made me read about that and I will avoid now on,
thank you very much.
I already reverted.
Harbs <ha...@gmail.com> escreveu no dia domingo, 30/01/2022 à(s)
09:35:
> This is not safe. We should not use innerHTML.
>
> Please revert.
>
> > On Jan 29, 2022, at 2:56 PM, hugoferreira@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > hugoferreira pushed a commit to branch develop
> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >
> >
> > The following commit(s) were added to refs/heads/develop by this push:
> > new bec3d1b The HTML CheckBox use now a span for the label so we
> can customize the look with css
> > new aa7ca1c Merge branch 'develop' of
> https://github.com/apache/royale-asjs into develop
> > bec3d1b is described below
> >
> > commit bec3d1baf36cff8776aa19f9ce4e73b94d16801b
> > Author: Hugo Ferreira <hf...@solidsoft.pt>
> > AuthorDate: Sat Jan 29 12:56:38 2022 +0000
> >
> > The HTML CheckBox use now a span for the label so we can customize
> the look with css
> > ---
> > .../Basic/src/main/royale/org/apache/royale/html/CheckBox.as | 6
> +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git
> a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
> b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
> > index ca18ff0..0bdd673 100644
> > ---
> a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
> > +++
> b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
> > @@ -159,7 +159,7 @@ package org.apache.royale.html
> > _icon = new CheckBoxIcon();
> > element.appendChild(_icon.element);
> >
> > - element.appendChild(document.createTextNode(''));
> > + element.appendChild(document.createElement('span'));
> > //positioner.style.position = 'relative';
> > _icon.element.royale_wrapper = this;
> >
> > @@ -170,12 +170,12 @@ package org.apache.royale.html
> >
> > public function get text():String
> > {
> > - return _label.childNodes.item(1).nodeValue;
> > + return _label.childNodes.item(1).innerHTML;
> > }
> >
> > public function set text(value:String):void
> > {
> > - _label.childNodes.item(1).nodeValue = value;
> > + _label.childNodes.item(1).innerHTML = value;
> > }
> >
> > /**
>
>
Re: [royale-asjs] branch develop updated: The HTML CheckBox use now a span for the label so we can customize the look with css
Posted by Harbs <ha...@gmail.com>.
This is not safe. We should not use innerHTML.
Please revert.
> On Jan 29, 2022, at 2:56 PM, hugoferreira@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> hugoferreira pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new bec3d1b The HTML CheckBox use now a span for the label so we can customize the look with css
> new aa7ca1c Merge branch 'develop' of https://github.com/apache/royale-asjs into develop
> bec3d1b is described below
>
> commit bec3d1baf36cff8776aa19f9ce4e73b94d16801b
> Author: Hugo Ferreira <hf...@solidsoft.pt>
> AuthorDate: Sat Jan 29 12:56:38 2022 +0000
>
> The HTML CheckBox use now a span for the label so we can customize the look with css
> ---
> .../Basic/src/main/royale/org/apache/royale/html/CheckBox.as | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
> index ca18ff0..0bdd673 100644
> --- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/CheckBox.as
> @@ -159,7 +159,7 @@ package org.apache.royale.html
> _icon = new CheckBoxIcon();
> element.appendChild(_icon.element);
>
> - element.appendChild(document.createTextNode(''));
> + element.appendChild(document.createElement('span'));
> //positioner.style.position = 'relative';
> _icon.element.royale_wrapper = this;
>
> @@ -170,12 +170,12 @@ package org.apache.royale.html
>
> public function get text():String
> {
> - return _label.childNodes.item(1).nodeValue;
> + return _label.childNodes.item(1).innerHTML;
> }
>
> public function set text(value:String):void
> {
> - _label.childNodes.item(1).nodeValue = value;
> + _label.childNodes.item(1).innerHTML = value;
> }
>
> /**