[ https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192036#comment-16192036 ]
ASF GitHub Bot commented on CB-13396:
-------------------------------------
GitHub user kenmickles opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/135
CB-13396: (ios) Fix image sizing on iOS 11
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS11 / iPhone X
### What does this PR do?
Prevent splash image from jumping around when CDVLaunchScreen.storyboard transitions to CDVSplashScreen.
### What testing has been done on this change?
Tested in these simulators:
- iPhone 6s / iOS 9.3
- iPhone 7 Plus / iOS 10.3
- iPhone 8 / iOS 11.0
- iPhone X / iOS 11.0
And on one device:
- iPhone 7 / iOS 11.0.1
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kenmickles/cordova-plugin-splashscreen master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 2223bd9eeedd512ad51c5981c19ba57395031e37
Author: Ken Mickles <ke...@37i.net>
Date: 2017-10-04T17:23:42Z
CB-13396: (ios) Fix image sizing on iOS 11
----
> Splash screen images are resized incorrectly on iPhone X
> --------------------------------------------------------
>
> Key: CB-13396
> URL: https://issues.apache.org/jira/browse/CB-13396
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
> Environment: iOS 11 / iPhone X
> Reporter: Ken Mickles
> Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into account, causing the image size to change when CDVLaunchScreen.storyboard transitions to the CDVSplashScreen image.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org