You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2019/01/11 22:46:48 UTC

[whimsy] branch master updated: Remove unused

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 27881bd  Remove unused
27881bd is described below

commit 27881bd8cff7bb05b3385a40bd9a7887e4069780
Author: Sebb <se...@apache.org>
AuthorDate: Fri Jan 11 22:46:46 2019 +0000

    Remove unused
---
 www/roster/models/nonpmc.rb | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/www/roster/models/nonpmc.rb b/www/roster/models/nonpmc.rb
index d110296..105e055 100644
--- a/www/roster/models/nonpmc.rb
+++ b/www/roster/models/nonpmc.rb
@@ -15,10 +15,7 @@ class NonPMC
       list =~ /^#{cttee.mail_list}\b/
     end
 
-    comdev = ASF::SVN['comdev-foundation']
-    info = JSON.parse(File.read(File.join(comdev, 'projects.json')))[id]
-
-    image_dir = ASF::SVN.find('site-img')
+    image_dir = ASF::SVN.find('site-img') # Probably not relevant to nonPMCS; leave for now
     image = Dir[File.join(image_dir, "#{id}.*")].map {|path| File.basename(path)}.last
 
     moderators = nil
@@ -29,7 +26,7 @@ class NonPMC
     unMatchedSubs = [] # unknown private@ subscribers
     unMatchedSecSubs = [] # unknown security@ subscribers
     currentUser = ASF::Person.find(env.user)
-    # TODO does not make sense for non-PMCs - remove the code
+    # Might make sense for non-PMCs - remove the code later if not
     analysePrivateSubs = false # whether to show missing private@ subscriptions
     if cttee.roster.include? env.user or currentUser.asf_member?
       require 'whimsy/asf/mlist'
@@ -136,15 +133,9 @@ class NonPMC
       }
     end
 
-    pmc_chair = false
-    if cttee.chair
-      pmcchairs = ASF::Service.find('cttee-chairs')
-      pmc_chair = pmcchairs.members.include? cttee.chair
-    end
     response = {
       id: id,
       chair: cttee.chair && cttee.chair.id,
-      pmc_chair: pmc_chair,
       display_name: cttee.display_name,
       description: cttee.description,
       schedule: cttee.schedule,
@@ -161,7 +152,6 @@ class NonPMC
       subscribers: subscribers,
       subtime: subtime,
       nonASFmails: nonASFmails,
-      project_info: info,
       image: image,
       guinea_pig: ASF::Committee::GUINEAPIGS.include?(id),
       analysePrivateSubs: analysePrivateSubs,