You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@horaedb.apache.org by "zealchen (via GitHub)" <gi...@apache.org> on 2024/11/01 05:24:05 UTC
Re: [PR] feat: add a cli tool to read wal meta information [horaedb]
zealchen commented on code in PR #1584:
URL: https://github.com/apache/horaedb/pull/1584#discussion_r1825438976
##########
src/wal/src/local_storage_impl/segment.rs:
##########
@@ -615,6 +615,32 @@ impl SegmentManager {
}
}
+pub struct SegmentTableMeta {
Review Comment:
To minimize exposing the internal objects, I chose not to return all the segments directly. Furthermore, since all_segments contain Mutexs, exposing it through the interface could compromise both safety and maintainability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org