[GitHub] [lucene] mayya-sharipova commented on a change in pull request #364: LUCENE-10154 NumericLeafComparator to define getPointValues

[GitBox <gi...@apache.org>]

mayya-sharipova commented on a change in pull request #364:
URL: https://github.com/apache/lucene/pull/364#discussion_r724507356



##########
File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
##########
@@ -130,12 +130,45 @@ public NumericLeafComparator(LeafReaderContext context) throws IOException {
       }
     }
 
-    /** Retrieves the NumericDocValues for the field in this segment */
+    /**
+     * Retrieves the NumericDocValues for the field in this segment
+     *
+     * <p>If you override this method, you must also override {@link
+     * #getPointValues(LeafReaderContext, String)} This class uses sort optimization that
+     * substitutes an iterator over doc_values with one over points, so it relies on the assumption

Review comment:
       Addressed in c4814f248b976ae2ae23173fc27319cb69d1c17d




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org