You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/03/28 07:36:57 UTC

[GitHub] [flink] link3280 commented on a change in pull request #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

link3280 commented on a change in pull request #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem
URL: https://github.com/apache/flink/pull/8068#discussion_r269883606
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
 ##########
 @@ -209,7 +209,7 @@ private SnapshotDirectory prepareLocalSnapshotDirectory(long checkpointId) throw
 			}
 		} else {
 			// create a "temporary" snapshot directory because local recovery is inactive.
-			Path path = new Path(instanceBasePath.getAbsolutePath(), "chk-" + checkpointId);
+			Path path = new Path(instanceBasePath.toURI().toString(), "chk-" + checkpointId);
 
 Review comment:
   Yes, that would look better. Thanks for your review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services