You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/03/28 21:38:47 UTC

[kudu-CR] KUDU-379: fix LESS_EQUAL predicates on float and double columns

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2647

to review the following change.

Change subject: KUDU-379: fix LESS_EQUAL predicates on float and double columns
......................................................................

KUDU-379: fix LESS_EQUAL predicates on float and double columns

This commit adds missing implementation of IncrementCell for float and double
columns, which fixes a TS crash when scanning with an inclusive upper-bound
predicate on float or double columns. This commit does not implement
IncrementCell for bool columns, since bool is not incrementable, and range
predicates on bool columns should be dissallowed. A follow up commit will add
the bool fix and extensive tests for predicates on all column types.

Change-Id: I46cc354b70effba51037f640358f4df5d1fc6657
---
M src/kudu/common/key_util.cc
1 file changed, 21 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/2647/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46cc354b70effba51037f640358f4df5d1fc6657
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>