You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/12 04:26:31 UTC

[GitHub] [airflow] mik-laj opened a new pull request #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations

mik-laj opened a new pull request #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations
URL: https://github.com/apache/airflow/pull/7404
 
 
   Hello,
   
   For operators from the Google package we have examples of DAGs and guides for the majority of integrations. Ther existence is already common, so we can enforce this rule for future integrations also.
   
   Best regards,
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations
URL: https://github.com/apache/airflow/pull/7404
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations
URL: https://github.com/apache/airflow/pull/7404#discussion_r378261236
 
 

 ##########
 File path: tests/test_project_structure.py
 ##########
 @@ -131,3 +131,124 @@ def test_keep_missing_test_files_update(self):
                 "Thank you very much.\n"
                 "Can you remove it from the list of missing tests, please?"
             )
+
+
+class TestGoogleProviderProjectStructure(unittest.TestCase):
+    MISSING_EXAMPLED_DAG = {
 
 Review comment:
   ```suggestion
       MISSING_EXAMPLE_DAG = {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations
URL: https://github.com/apache/airflow/pull/7404#issuecomment-585205003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7404?src=pr&el=h1) Report
   > Merging [#7404](https://codecov.io/gh/apache/airflow/pull/7404?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/967930c0cb6e2293f2a49e5c9add5aa1917f3527?src=pr&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7404/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7404?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7404      +/-   ##
   ==========================================
   - Coverage   86.61%   86.33%   -0.28%     
   ==========================================
     Files         873      874       +1     
     Lines       40757    40868     +111     
   ==========================================
   - Hits        35300    35284      -16     
   - Misses       5457     5584     +127
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7404?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7404/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7404/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7404/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7404/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7404/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/7404/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `65.38% <0%> (-6.36%)` | :arrow_down: |
   | [airflow/utils/log/stackdriver\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7404/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvc3RhY2tkcml2ZXJfdGFza19oYW5kbGVyLnB5) | `97.14% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7404?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7404?src=pr&el=footer). Last update [967930c...23d2efe](https://codecov.io/gh/apache/airflow/pull/7404?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7404: [AIRFLOW-6781] Enforce example_dags and guide for Google integrations
URL: https://github.com/apache/airflow/pull/7404#discussion_r378854850
 
 

 ##########
 File path: tests/test_project_structure.py
 ##########
 @@ -131,3 +131,124 @@ def test_keep_missing_test_files_update(self):
                 "Thank you very much.\n"
                 "Can you remove it from the list of missing tests, please?"
             )
+
+
+class TestGoogleProviderProjectStructure(unittest.TestCase):
+    MISSING_EXAMPLED_DAG = {
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services