You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/12 20:44:56 UTC
Review Request 29006: Added output streaming for persistence id.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29006/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2030
https://issues.apache.org/jira/browse/MESOS-2030
Repository: mesos-git
Description
-------
Added output streaming for persistence id. Do not include the 'container_path' for now as we can always print that on slaves. The id is the most important for debugging and triaging.
Diffs
-----
src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e
Diff: https://reviews.apache.org/r/29006/diff/
Testing
-------
make check
also manually verify the logs
Thanks,
Jie Yu
Re: Review Request 29006: Added output streaming for persistence id.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29006/#review64969
-----------------------------------------------------------
Bad patch!
Reviews applied: [28711, 28720]
Failed command: ./support/apply-review.sh -n -r 28720
Error:
2014-12-12 20:05:05 URL:https://reviews.apache.org/r/28720/diff/raw/ [9603/9603] -> "28720.patch" [1]
error: patch failed: src/master/master.cpp:1796
error: src/master/master.cpp: patch does not apply
error: patch failed: src/tests/resource_offers_tests.cpp:256
error: src/tests/resource_offers_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 12, 2014, 7:44 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29006/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 7:44 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added output streaming for persistence id. Do not include the 'container_path' for now as we can always print that on slaves. The id is the most important for debugging and triaging.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e
>
> Diff: https://reviews.apache.org/r/29006/diff/
>
>
> Testing
> -------
>
> make check
> also manually verify the logs
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29006: Added output streaming for persistence id.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29006/#review65441
-----------------------------------------------------------
src/common/resources.cpp
<https://reviews.apache.org/r/29006/#comment108578>
Don't you need to change the `Resources::parse(...)` methods if you change this?
- Ben Mahler
On Dec. 12, 2014, 7:44 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29006/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 7:44 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added output streaming for persistence id. Do not include the 'container_path' for now as we can always print that on slaves. The id is the most important for debugging and triaging.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e
>
> Diff: https://reviews.apache.org/r/29006/diff/
>
>
> Testing
> -------
>
> make check
> also manually verify the logs
>
>
> Thanks,
>
> Jie Yu
>
>