You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/03 13:03:59 UTC

[GitHub] [commons-lang] iashok22 opened a new pull request #669: Adding method to convert and format date

iashok22 opened a new pull request #669:
URL: https://github.com/apache/commons-lang/pull/669


   given Unix epoch time will be converted to date string with given date format.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #669: Adding method to convert and format date

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #669:
URL: https://github.com/apache/commons-lang/pull/669#issuecomment-749155069


   Hi @iashok22 
   
   Thank you for your PR.
   
   This seems to duplicate `FastDateFormat.getInstance(pattern).format(long)` which uses a format cache. 
   
   The new method is the same as `new SimpleDateFormat(format).format(long)` (which does not use a cache) so I do not see the value here.
   
   Am I missing something?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory closed pull request #669: Adding method to convert and format date

Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #669:
URL: https://github.com/apache/commons-lang/pull/669


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls commented on pull request #669: Adding method to convert and format date

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #669:
URL: https://github.com/apache/commons-lang/pull/669#issuecomment-738212439


   
   [![Coverage Status](https://coveralls.io/builds/35429865/badge)](https://coveralls.io/builds/35429865)
   
   Coverage decreased (-0.01%) to 95.008% when pulling **a28e92333377ec50d57cffedc63ac3420940a7ec on iashok22:master** into **8c66a5fcb7f08aba86bbb1efeaa0a2e1f42d4e16 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls edited a comment on pull request #669: Adding method to convert and format date

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #669:
URL: https://github.com/apache/commons-lang/pull/669#issuecomment-738212439


   
   [![Coverage Status](https://coveralls.io/builds/35448211/badge)](https://coveralls.io/builds/35448211)
   
   Coverage increased (+0.0009%) to 95.014% when pulling **5433e508795125e49e7032b599ff1749a51e46a3 on iashok22:master** into **66b54723f09e63eb7930a33c365b3214afaa1990 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #669: Adding method to convert and format date

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #669:
URL: https://github.com/apache/commons-lang/pull/669#issuecomment-782873413


   No response in 2 months, closing.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org