[GitHub] [rocketmq] liuruiyiyang commented on a change in pull request #1345: [ISSUE #1344] Fix /dev/shm not found on some OSs

[GitBox <gi...@apache.org>]

liuruiyiyang commented on a change in pull request #1345: [ISSUE #1344] Fix /dev/shm not found on some OSs
URL: https://github.com/apache/rocketmq/pull/1345#discussion_r308237611
 
 

 ##########
 File path: distribution/benchmark/runclass.sh
 ##########
 @@ -24,13 +24,39 @@ fi
 BASE_DIR=$(dirname $0)/..
 CLASSPATH=.:${BASE_DIR}/conf:${CLASSPATH}
 
+choose_gc_log_directory()
+{
+    case "`uname`" in
+        Darwin)
+            if [ ! -d "/Volumes/RAMDisk" ]; then
+                # create ram disk on Darwin systems as gc-log directory, default size is 600MB
+                DIR_SIZE_IN_MB=600
 
 Review comment:
   Do you mean that I should put it in a config file? or move it outside the choose_gc_log_directory function as a parameter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services