[GitHub] [beam] lostluck commented on a diff in pull request #26183: (#26180) Fix go-licenses container COPY, by touching a dummy file.

["lostluck (via GitHub)" <gi...@apache.org>]

lostluck commented on code in PR #26183:
URL: https://github.com/apache/beam/pull/26183#discussion_r1161927266


##########
sdks/go/container/Dockerfile:
##########
@@ -34,11 +35,8 @@ ADD target/${TARGETOS}_${TARGETARCH}/boot /opt/apache/beam/
 COPY target/LICENSE /opt/apache/beam/
 COPY target/NOTICE /opt/apache/beam/
 
-# Add golang licenses. Because the go-license directory may be empty if
-# pull_licenses is false, and COPY fails if there are no files,
-# copy an extra LICENSE file then remove it.
-COPY target/LICENSE target/go-licenses/* /opt/apache/beam/third_party_licenses/golang/
-RUN rm /opt/apache/beam/third_party_licenses/golang/LICENSE
+# Add Go licenses.
+COPY target/go-licenses/* /opt/apache/beam/third_party_licenses/golang/

Review Comment:
   The dummy is only generated on the skip path. And in the skip path, the
   entire folder for licenses is deleted. An explicit delete is redundant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org