You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by vsair <gi...@git.apache.org> on 2017/04/17 09:27:05 UTC

[GitHub] incubator-rocketmq pull request #94: [ROCKETMQ-179] Fix errors of test cases

GitHub user vsair opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/94

    [ROCKETMQ-179] Fix errors of test cases

    1. Add TC of ConsumerManager.
    2. Fix some bugs.
    3. Set file size of commitlog to 256M, instead of 1G(may too big).
    4. Destroy message store in shutdown hook, otherwise could not clear the files generated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vsair/incubator-rocketmq ROCKETMQ-179

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #94
    
----
commit a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099
Author: xigu.lx <xi...@alibaba-inc.com>
Date:   2017-04-17T09:25:55Z

    [ROCKETMQ-179] Fix errors of test cases
    1. Add TC of ConsumerManager.
    2. Fix some bugs.
    3. Set file size of commitlog to 256M, instead of 1G(may too big).
    4. Destroy message store in shutdown hook, otherwise could not clear the files generated.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #94: [ROCKETMQ-179] Fix errors of test cases

Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/94
  
    Nice. This PR could be merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #94: [ROCKETMQ-179] Fix errors of test cases

Posted by vsair <gi...@git.apache.org>.
Github user vsair closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/94


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #94: [ROCKETMQ-179] Fix errors of test cases

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/94
  
    
    [![Coverage Status](https://coveralls.io/builds/11108290/badge)](https://coveralls.io/builds/11108290)
    
    Coverage increased (+0.07%) to 34.693% when pulling **a0902a3dc6f2b7ae7232c9ea9bd8d006bd757099 on vsair:ROCKETMQ-179** into **7bcb3b3eae1e3c441861f2a3cd79ff54a8e691b9 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #94: [ROCKETMQ-179] Fix errors of test cases

Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/94
  
    Great~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---