[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #589: LOG4J2-3174: Wrong subject on mail when it depends on the LogEvent

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r731293695



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##########
@@ -273,10 +273,11 @@ protected MimeMultipart getMimeMultipart(final byte[] encodedBytes, final Intern
         return mp;
     }
 
-    protected void sendMultipartMessage(final MimeMessage msg, final MimeMultipart mp) throws MessagingException {
+    protected void sendMultipartMessage(final MimeMessage msg, final MimeMultipart mp, final String subject) throws MessagingException {

Review comment:
       Breaking BC here is fine IMO. AFAIC, we only provide BC in the API module, and keep BC elsewhere when convenient. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org