[GitHub] john-bodley commented on a change in pull request #4202: [line chart] fix time shift color

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #4202: [line chart] fix time shift color
URL: https://github.com/apache/incubator-superset/pull/4202#discussion_r161291243
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -939,7 +939,7 @@ def to_series(self, df, classed='', title_suffix=''):
             if isinstance(series_title, string_types):
                 series_title += title_suffix
             elif title_suffix and isinstance(series_title, (list, tuple)):
-                series_title = series_title + (title_suffix,)
+                series_title = str(series_title[-1]) + title_suffix
 
 Review comment:
   Can the series title contain unicode characters? If so should this be `six.string_types(...)` rather than `str(...)` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services