[jira] [Comment Edited] (YARN-3334) [Event Producers] NM TimelineClient life cycle handling and container metrics posting to new timeline service.

["Zhijie Shen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387523#comment-14387523 ] 

Zhijie Shen edited comment on YARN-3334 at 3/30/15 10:37 PM:
-------------------------------------------------------------

[~djp], [~sjlee0], [~gtCarrera9], per may previous comments, IMHO, the bug around {{getTimelineClient(ApplicationId id)}} is not around map operation. The client *only* needs to be created for app that has the container on this NM. The client should be created and inited when ApplicationImpl is inited and stopped and removed when ApplicationImpl is finished.

PS: it seems that we even don't need to maintain the client map in the context. we can add the client as the member variable of ApplicationImpl. In context, we already have the app map. So we can get the client with {{context.getApplications.get(appId).getTimelineClient()}} to get it.


was (Author: zjshen):
[~djp], [~sjlee0], [~gtCarrera9], per may previous comments, IMHO, the bug arround {{getTimelineClient(ApplicationId id)}} is not around map operation. The client *only* needs to be created for app that has the container on this NM. The client should be created and inited when ApplicationImpl is inited and stopped and removed when ApplicationImpl is finished.

> [Event Producers] NM TimelineClient life cycle handling and container metrics posting to new timeline service.
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3334
>                 URL: https://issues.apache.org/jira/browse/YARN-3334
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: YARN-2928
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: YARN-3334-demo.patch, YARN-3334-v1.patch, YARN-3334-v2.patch, YARN-3334-v3.patch
>
>
> After YARN-3039, we have service discovery mechanism to pass app-collector service address among collectors, NMs and RM. In this JIRA, we will handle service address setting for TimelineClients in NodeManager, and put container metrics to the backend storage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)