You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2019/01/26 01:44:20 UTC
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12277
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
IMPALA-8062: Call impala-config in single_node_perf_run
This wraps most shell calls in single_node_perf_run.py with a bash
shell that first sources impala-config.sh, to make sure environment
variables are set properly.
Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
---
M bin/single_node_perf_run.py
1 file changed, 19 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12277/1
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12277
to look at the new patch set (#2).
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
IMPALA-8062: Call impala-config in single_node_perf_run
This wraps most shell calls in single_node_perf_run.py with a bash
shell that first sources impala-config.sh, to make sure environment
variables are set properly.
Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
---
M bin/single_node_perf_run.py
1 file changed, 20 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12277/2
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1901/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Jan 2019 03:45:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12277/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12277/1//COMMIT_MSG@11
PS1, Line 11: variables are set properly.
How did you test?
http://gerrit.cloudera.org:8080/#/c/12277/1/bin/single_node_perf_run.py
File bin/single_node_perf_run.py:
http://gerrit.cloudera.org:8080/#/c/12277/1/bin/single_node_perf_run.py@84
PS1, Line 84: cmd = " ".join(cmd)
Might not be a major issue in practice, but it would be better run to run the tokens through pipes.quote() to make sure that it doesn't get re-tokenized by the shell in the wrong way.
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Jan 2019 01:48:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Jan 2019 03:04:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Jan 2019 22:28:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3678/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Jan 2019 23:11:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12277/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12277/1//COMMIT_MSG@11
PS1, Line 11: variables are set properly.
> How did you test?
I just ran it on my development machine and checked that it completed as usual.
http://gerrit.cloudera.org:8080/#/c/12277/1/bin/single_node_perf_run.py
File bin/single_node_perf_run.py:
http://gerrit.cloudera.org:8080/#/c/12277/1/bin/single_node_perf_run.py@84
PS1, Line 84: if type(cmd) is list:
> Might not be a major issue in practice, but it would be better run to run t
Done
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Jan 2019 03:16:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
IMPALA-8062: Call impala-config in single_node_perf_run
This wraps most shell calls in single_node_perf_run.py with a bash
shell that first sources impala-config.sh, to make sure environment
variables are set properly.
Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Reviewed-on: http://gerrit.cloudera.org:8080/12277
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/single_node_perf_run.py
1 file changed, 20 insertions(+), 11 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1898/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Jan 2019 02:43:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8062: Call impala-config in single node perf run
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Jan 2019 23:11:54 +0000
Gerrit-HasComments: No