You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/11/07 19:09:10 UTC

Review Request 15315: [HELIX-291] Update master POM files to say current version is 0.7.0

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15315/
-----------------------------------------------------------

Review request for helix, Zhen Zhang and Kishore Gopalakrishna.


Bugs: HELIX-291


Repository: helix-git


Description
-------

commit ba252140695edfc393c95dad98b633f6b27ebc76
Author: Kanak Biscuitwala <ka...@apache.org>
Date:   Thu Nov 7 10:08:12 2013 -0800

    [HELIX-291] Update master POM files to say current version is 0.7.0

:100644 100644 7791f92... 4bda29f... M	helix-admin-webapp/pom.xml
:100644 100644 73dd5fc... e2d38d9... M	helix-agent/pom.xml
:100644 100644 12d3c9f... 24391c1... M	helix-core/pom.xml
:100644 100644 fca2d97... 3a9b574... M	helix-examples/pom.xml
:100644 100644 9abf7fc... 16ded25... M	pom.xml
:100644 100644 0b5d1e4... cb4fe7d... M	recipes/distributed-lock-manager/pom.xml
:100644 100644 3667650... 574cff5... M	recipes/pom.xml
:100644 100644 111c3ca... 7ff7be3... M	recipes/rabbitmq-consumer-group/pom.xml
:100644 100644 3e7e08b... 304113b... M	recipes/rsync-replicated-file-system/pom.xml
:100644 100644 e1c45e8... d9e2742... M	recipes/service-discovery/pom.xml
:100644 100644 8f8683c... 1ec08fd... M	recipes/task-execution/pom.xml
:100644 100644 ebd972c... 8b99fb6... M	recipes/user-defined-rebalancer/pom.xml
:100644 100644 2b4f7f5... 04ddc9f... M	site-releases/0.6.1-incubating/pom.xml
:100644 100644 13b86be... bb3417a... M	site-releases/pom.xml


Diffs
-----

  helix-admin-webapp/pom.xml 7791f92 
  helix-agent/pom.xml 73dd5fc 
  helix-core/pom.xml 12d3c9f 
  helix-examples/pom.xml fca2d97 
  pom.xml 9abf7fc 
  recipes/distributed-lock-manager/pom.xml 0b5d1e4 
  recipes/pom.xml 3667650 
  recipes/rabbitmq-consumer-group/pom.xml 111c3ca 
  recipes/rsync-replicated-file-system/pom.xml 3e7e08b 
  recipes/service-discovery/pom.xml e1c45e8 
  recipes/task-execution/pom.xml 8f8683c 
  recipes/user-defined-rebalancer/pom.xml ebd972c 
  site-releases/0.6.1-incubating/pom.xml 2b4f7f5 
  site-releases/pom.xml 13b86be 

Diff: https://reviews.apache.org/r/15315/diff/


Testing
-------

Builds successfully


Thanks,

Kanak Biscuitwala


Re: Review Request 15315: [HELIX-291] Update master POM files to say current version is 0.7.0

Posted by Kanak Biscuitwala <ka...@apache.org>.

> On Nov. 7, 2013, 10:23 a.m., Kishore Gopalakrishna wrote:
> > site-releases/0.6.1-incubating/pom.xml, line 26
> > <https://reviews.apache.org/r/15315/diff/1/?file=380479#file380479line26>
> >
> >     why is the name of this file containing version number.

That is the version of the parent project. Since the top level project has a version, all child projects have to refer to that specific version all the way down, even for site projects. Otherwise maven complains about not knowing the parent version.


- Kanak


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15315/#review28392
-----------------------------------------------------------


On Nov. 7, 2013, 10:09 a.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15315/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 10:09 a.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-291
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit ba252140695edfc393c95dad98b633f6b27ebc76
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date:   Thu Nov 7 10:08:12 2013 -0800
> 
>     [HELIX-291] Update master POM files to say current version is 0.7.0
> 
> :100644 100644 7791f92... 4bda29f... M	helix-admin-webapp/pom.xml
> :100644 100644 73dd5fc... e2d38d9... M	helix-agent/pom.xml
> :100644 100644 12d3c9f... 24391c1... M	helix-core/pom.xml
> :100644 100644 fca2d97... 3a9b574... M	helix-examples/pom.xml
> :100644 100644 9abf7fc... 16ded25... M	pom.xml
> :100644 100644 0b5d1e4... cb4fe7d... M	recipes/distributed-lock-manager/pom.xml
> :100644 100644 3667650... 574cff5... M	recipes/pom.xml
> :100644 100644 111c3ca... 7ff7be3... M	recipes/rabbitmq-consumer-group/pom.xml
> :100644 100644 3e7e08b... 304113b... M	recipes/rsync-replicated-file-system/pom.xml
> :100644 100644 e1c45e8... d9e2742... M	recipes/service-discovery/pom.xml
> :100644 100644 8f8683c... 1ec08fd... M	recipes/task-execution/pom.xml
> :100644 100644 ebd972c... 8b99fb6... M	recipes/user-defined-rebalancer/pom.xml
> :100644 100644 2b4f7f5... 04ddc9f... M	site-releases/0.6.1-incubating/pom.xml
> :100644 100644 13b86be... bb3417a... M	site-releases/pom.xml
> 
> 
> Diffs
> -----
> 
>   helix-admin-webapp/pom.xml 7791f92 
>   helix-agent/pom.xml 73dd5fc 
>   helix-core/pom.xml 12d3c9f 
>   helix-examples/pom.xml fca2d97 
>   pom.xml 9abf7fc 
>   recipes/distributed-lock-manager/pom.xml 0b5d1e4 
>   recipes/pom.xml 3667650 
>   recipes/rabbitmq-consumer-group/pom.xml 111c3ca 
>   recipes/rsync-replicated-file-system/pom.xml 3e7e08b 
>   recipes/service-discovery/pom.xml e1c45e8 
>   recipes/task-execution/pom.xml 8f8683c 
>   recipes/user-defined-rebalancer/pom.xml ebd972c 
>   site-releases/0.6.1-incubating/pom.xml 2b4f7f5 
>   site-releases/pom.xml 13b86be 
> 
> Diff: https://reviews.apache.org/r/15315/diff/
> 
> 
> Testing
> -------
> 
> Builds successfully
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>


Re: Review Request 15315: [HELIX-291] Update master POM files to say current version is 0.7.0

Posted by Kanak Biscuitwala <ka...@apache.org>.

> On Nov. 7, 2013, 10:23 a.m., Kishore Gopalakrishna wrote:
> > site-releases/0.6.1-incubating/pom.xml, line 26
> > <https://reviews.apache.org/r/15315/diff/1/?file=380479#file380479line26>
> >
> >     why is the name of this file containing version number.
> 
> Kanak Biscuitwala wrote:
>     That is the version of the parent project. Since the top level project has a version, all child projects have to refer to that specific version all the way down, even for site projects. Otherwise maven complains about not knowing the parent version.

Oh, I misunderstood your question. It's because this package includes webpages (excluding javadocs) for that particular release.


- Kanak


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15315/#review28392
-----------------------------------------------------------


On Nov. 7, 2013, 10:09 a.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15315/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 10:09 a.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-291
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit ba252140695edfc393c95dad98b633f6b27ebc76
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date:   Thu Nov 7 10:08:12 2013 -0800
> 
>     [HELIX-291] Update master POM files to say current version is 0.7.0
> 
> :100644 100644 7791f92... 4bda29f... M	helix-admin-webapp/pom.xml
> :100644 100644 73dd5fc... e2d38d9... M	helix-agent/pom.xml
> :100644 100644 12d3c9f... 24391c1... M	helix-core/pom.xml
> :100644 100644 fca2d97... 3a9b574... M	helix-examples/pom.xml
> :100644 100644 9abf7fc... 16ded25... M	pom.xml
> :100644 100644 0b5d1e4... cb4fe7d... M	recipes/distributed-lock-manager/pom.xml
> :100644 100644 3667650... 574cff5... M	recipes/pom.xml
> :100644 100644 111c3ca... 7ff7be3... M	recipes/rabbitmq-consumer-group/pom.xml
> :100644 100644 3e7e08b... 304113b... M	recipes/rsync-replicated-file-system/pom.xml
> :100644 100644 e1c45e8... d9e2742... M	recipes/service-discovery/pom.xml
> :100644 100644 8f8683c... 1ec08fd... M	recipes/task-execution/pom.xml
> :100644 100644 ebd972c... 8b99fb6... M	recipes/user-defined-rebalancer/pom.xml
> :100644 100644 2b4f7f5... 04ddc9f... M	site-releases/0.6.1-incubating/pom.xml
> :100644 100644 13b86be... bb3417a... M	site-releases/pom.xml
> 
> 
> Diffs
> -----
> 
>   helix-admin-webapp/pom.xml 7791f92 
>   helix-agent/pom.xml 73dd5fc 
>   helix-core/pom.xml 12d3c9f 
>   helix-examples/pom.xml fca2d97 
>   pom.xml 9abf7fc 
>   recipes/distributed-lock-manager/pom.xml 0b5d1e4 
>   recipes/pom.xml 3667650 
>   recipes/rabbitmq-consumer-group/pom.xml 111c3ca 
>   recipes/rsync-replicated-file-system/pom.xml 3e7e08b 
>   recipes/service-discovery/pom.xml e1c45e8 
>   recipes/task-execution/pom.xml 8f8683c 
>   recipes/user-defined-rebalancer/pom.xml ebd972c 
>   site-releases/0.6.1-incubating/pom.xml 2b4f7f5 
>   site-releases/pom.xml 13b86be 
> 
> Diff: https://reviews.apache.org/r/15315/diff/
> 
> 
> Testing
> -------
> 
> Builds successfully
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>


Re: Review Request 15315: [HELIX-291] Update master POM files to say current version is 0.7.0

Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15315/#review28392
-----------------------------------------------------------



site-releases/0.6.1-incubating/pom.xml
<https://reviews.apache.org/r/15315/#comment55222>

    why is the name of this file containing version number.


- Kishore Gopalakrishna


On Nov. 7, 2013, 6:09 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15315/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 6:09 p.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-291
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit ba252140695edfc393c95dad98b633f6b27ebc76
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date:   Thu Nov 7 10:08:12 2013 -0800
> 
>     [HELIX-291] Update master POM files to say current version is 0.7.0
> 
> :100644 100644 7791f92... 4bda29f... M	helix-admin-webapp/pom.xml
> :100644 100644 73dd5fc... e2d38d9... M	helix-agent/pom.xml
> :100644 100644 12d3c9f... 24391c1... M	helix-core/pom.xml
> :100644 100644 fca2d97... 3a9b574... M	helix-examples/pom.xml
> :100644 100644 9abf7fc... 16ded25... M	pom.xml
> :100644 100644 0b5d1e4... cb4fe7d... M	recipes/distributed-lock-manager/pom.xml
> :100644 100644 3667650... 574cff5... M	recipes/pom.xml
> :100644 100644 111c3ca... 7ff7be3... M	recipes/rabbitmq-consumer-group/pom.xml
> :100644 100644 3e7e08b... 304113b... M	recipes/rsync-replicated-file-system/pom.xml
> :100644 100644 e1c45e8... d9e2742... M	recipes/service-discovery/pom.xml
> :100644 100644 8f8683c... 1ec08fd... M	recipes/task-execution/pom.xml
> :100644 100644 ebd972c... 8b99fb6... M	recipes/user-defined-rebalancer/pom.xml
> :100644 100644 2b4f7f5... 04ddc9f... M	site-releases/0.6.1-incubating/pom.xml
> :100644 100644 13b86be... bb3417a... M	site-releases/pom.xml
> 
> 
> Diffs
> -----
> 
>   helix-admin-webapp/pom.xml 7791f92 
>   helix-agent/pom.xml 73dd5fc 
>   helix-core/pom.xml 12d3c9f 
>   helix-examples/pom.xml fca2d97 
>   pom.xml 9abf7fc 
>   recipes/distributed-lock-manager/pom.xml 0b5d1e4 
>   recipes/pom.xml 3667650 
>   recipes/rabbitmq-consumer-group/pom.xml 111c3ca 
>   recipes/rsync-replicated-file-system/pom.xml 3e7e08b 
>   recipes/service-discovery/pom.xml e1c45e8 
>   recipes/task-execution/pom.xml 8f8683c 
>   recipes/user-defined-rebalancer/pom.xml ebd972c 
>   site-releases/0.6.1-incubating/pom.xml 2b4f7f5 
>   site-releases/pom.xml 13b86be 
> 
> Diff: https://reviews.apache.org/r/15315/diff/
> 
> 
> Testing
> -------
> 
> Builds successfully
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>