You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/11 20:35:21 UTC
[GitHub] [airflow] ashb opened a new pull request #14731: Reduce duplication in pre_commit_check_order_setup.py script
ashb opened a new pull request #14731:
URL: https://github.com/apache/airflow/pull/14731
Now that we are using Py3.6+ we can rely on dictionary key order to be fixed (it was always fixed in 3.6, just not explicitly documented as such from 3.7) -- as a result we can load the source, rather than try to parse it with regexes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14731: Reduce duplication in pre_commit_check_order_setup.py script
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14731:
URL: https://github.com/apache/airflow/pull/14731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14731: Reduce duplication in pre_commit_check_order_setup.py script
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14731:
URL: https://github.com/apache/airflow/pull/14731#issuecomment-797054614
Static checks passed, merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14731: Reduce duplication in pre_commit_check_order_setup.py script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14731:
URL: https://github.com/apache/airflow/pull/14731#issuecomment-797040823
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org