You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/02 17:31:32 UTC
[GitHub] [kafka] tombentley opened a new pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion
tombentley opened a new pull request #10023:
URL: https://github.com/apache/kafka/pull/10023
As described in [KAFKA-12263](https://issues.apache.org/jira/browse/KAFKA-12263), this PR refactors `MockClient.RequestMatcher` to become `MockClient.RequestAssertion` using assertions in the implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10023:
URL: https://github.com/apache/kafka/pull/10023#issuecomment-784937295
@hachikuji any chance you could take a look, since you opened KAFKA-12263?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10023:
URL: https://github.com/apache/kafka/pull/10023#issuecomment-828376561
@hachikuji any chance you could review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10023:
URL: https://github.com/apache/kafka/pull/10023#issuecomment-771821577
@hachikuji since you raised the JIRA perhaps you could review this to check it's what you were after?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10023:
URL: https://github.com/apache/kafka/pull/10023#issuecomment-771821577
@hachikuji since you raised the JIRA perhaps you could review this to check it's what you were after?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org