You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/14 09:45:35 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #8590: Update ZooKeeper to 3.6.2 and Curator to 5.1.0

sijie commented on a change in pull request #8590:
URL: https://github.com/apache/pulsar/pull/8590#discussion_r557265281



##########
File path: managed-ledger/pom.xml
##########
@@ -84,7 +84,16 @@
       <classifier>tests</classifier>
       <scope>test</scope>
     </dependency>
-
+    <dependency>
+       <groupId>io.dropwizard.metrics</groupId>

Review comment:
       Can you explain why do we need this? I failed to see this dependency was used here. The same question apply to the other dependency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org