[GitHub] [spark] huaxingao commented on a change in pull request #28045: [SPARK-31283][ML] Simplify ChiSq by adding a common method

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #28045: [SPARK-31283][ML] Simplify ChiSq by adding a common method
URL: https://github.com/apache/spark/pull/28045#discussion_r399687400
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/mllib/stat/test/ChiSqTest.scala
 ##########
 @@ -224,12 +170,11 @@ private[spark] object ChiSqTest extends Logging {
 
     if (results.size < numFeatures) {
 
 Review comment:
   Seems the test suite doesn't cover this ```if (results.size < numFeatures)``` path? Is it worth adding the coverage?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org