You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by bilak <gi...@git.apache.org> on 2016/03/31 11:50:43 UTC
[GitHub] cxf pull request: - implemented AutoCloseable Client
GitHub user bilak opened a pull request:
https://github.com/apache/cxf/pull/124
- implemented AutoCloseable Client
Implemented AutoCloseable interface which simple calls destroy() method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bilak/cxf master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit ebbdc4b1df0be9bbcf06236c02c0d9746c9e6683
Author: bilak <bi...@gmail.com>
Date: 2016-03-31T09:44:32Z
- implemented AutoCloseable Client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: - implemented AutoCloseable Client
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/124#issuecomment-212021075
No problem. I had also had a lot of issue with git when I started. I just updated the getting involved guide to show how you ideally structure your work in git. https://cxf.apache.org/getting-involved.html
It does not show the git commands you need but how it should look like.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #124: - implemented AutoCloseable Client
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cxf/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: - implemented AutoCloseable Client
Posted by bilak <gi...@git.apache.org>.
Github user bilak commented on the pull request:
https://github.com/apache/cxf/pull/124#issuecomment-211990480
Yes I've reformatted the code because I didn't knew about your formatter (then I found it). So probably you can fix the issue better if you know how. Sorry for bundling all commits to one PR, I'm not using git too long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: - implemented AutoCloseable Client
Posted by cschneider <gi...@git.apache.org>.
Github user cschneider commented on the pull request:
https://github.com/apache/cxf/pull/124#issuecomment-211961022
This code does not seem to build. I got somee checkstyle errors.
I also think setting the classloader on the bus is not correct as the bus may be for a complete
bundle. So setting it when a DynamicClient is created and removing it when it is removed does not seem to be valid for all cases.
Pelase also try to not reformat the code in commits that also change the logic as this makes it a lot harder to review.
Ideally you should create one branch / pull request per jira issue and make sure the code builds on your machine using mvn clean install.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: - implemented AutoCloseable Client
Posted by tomitribe-dev <gi...@git.apache.org>.
Github user tomitribe-dev commented on the pull request:
https://github.com/apache/cxf/pull/124#issuecomment-218431543
Build finished. 0 tests run, 0 skipped, 0 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: - implemented AutoCloseable Client
Posted by tomitribe-dev <gi...@git.apache.org>.
Github user tomitribe-dev commented on the pull request:
https://github.com/apache/cxf/pull/124#issuecomment-218430590
Build triggered. sha1 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: - implemented AutoCloseable Client
Posted by tomitribe-dev <gi...@git.apache.org>.
Github user tomitribe-dev commented on the pull request:
https://github.com/apache/cxf/pull/124#issuecomment-218431530
Build started sha1 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---