You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/29 12:27:49 UTC
[GitHub] [camel] vilmosnagy opened a new pull request #4960: [CAMEL-16108] The S3 metadata is included in the Exchange as a Header
vilmosnagy opened a new pull request #4960:
URL: https://github.com/apache/camel/pull/4960
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vilmosnagy commented on pull request #4960: [CAMEL-16108] The S3 metadata is included in the Exchange as a Header
Posted by GitBox <gi...@apache.org>.
vilmosnagy commented on pull request #4960:
URL: https://github.com/apache/camel/pull/4960#issuecomment-769777278
@oscerd Could you help me where should I write the documentation for this? And how?
As I've searched for examples in the project I've found the following:
- the `CamelAwsS3BucketName` is documented in the `generated/docs` folder. Should I document this header in that file as well? Then why it's in the `generated` folder?
- and I can't find any documentation for the `CamelAwsS3DowloadLinkExpirationTime` header (ps.: there's a typo in that header)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #4960: [CAMEL-16108] The S3 metadata is included in the Exchange as a Header
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #4960:
URL: https://github.com/apache/camel/pull/4960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4960: [CAMEL-16108] The S3 metadata is included in the Exchange as a Header
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4960:
URL: https://github.com/apache/camel/pull/4960#issuecomment-769801366
@vilmosnagy all the documentation is in the src/main/docs of the componet, the src/generated stuff is auto-regenerated when you build the component. You can add the documentation in src/main/docs, there is only one adoc file.
For the header I think we need to fix the error and add a note in the migration guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4960: [CAMEL-16108] The S3 metadata is included in the Exchange as a Header
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4960:
URL: https://github.com/apache/camel/pull/4960#issuecomment-769878273
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vilmosnagy commented on pull request #4960: [CAMEL-16108] The S3 metadata is included in the Exchange as a Header
Posted by GitBox <gi...@apache.org>.
vilmosnagy commented on pull request #4960:
URL: https://github.com/apache/camel/pull/4960#issuecomment-769802637
@oscerd Thanks for the clarification, I've pushed the docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org