You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/21 23:04:31 UTC

[GitHub] [pulsar] merlimat opened a new pull request #10674: Revert "Creating a topic does not wait for creating cursor of replicators"

merlimat opened a new pull request #10674:
URL: https://github.com/apache/pulsar/pull/10674


   
   
   This reverts  #6364 commit 336e971f4d41d6ffb26b3b53a20f36a360c070e8.
   
   ### Motivation
   
   There are few issues that were introduced in that commit: 
    1. If a new replication cursor is create after the topic is loaded, that cursor might be missing some of the latest messages
    2. Many places in the code are assuming that the cursor is always present on the replicator and are failing with NPE when the cursor is not created (or fails to get created).
   
   One such example is that metrics will stop getting reported because of an exception: 
   
   ```
   ERROR org.apache.pulsar.broker.stats.prometheus.PrometheusMetricsServlet - Failed to generate prometheus stats 
   java.lang.NullPointerException: null                                                                                                                
            at org.apache.pulsar.broker.service.persistent.PersistentReplicator.getStats(PersistentReplicator.java:676) ~[org.apache.pulsar-pulsar-broker-2.7.
            at org.apache.pulsar.broker.service.persistent.PersistentTopic.lambda$getStats$45(PersistentTopic.java:1624) ~[org.apache.pulsar-pulsar-broker-2.7
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10674: Revert "Creating a topic does not wait for creating cursor of replicators"

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10674:
URL: https://github.com/apache/pulsar/pull/10674


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org