You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/22 15:46:17 UTC
[GitHub] [kafka] cadonna opened a new pull request #8532: HOTFIX: Fix broker bounce system tests
cadonna opened a new pull request #8532:
URL: https://github.com/apache/kafka/pull/8532
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on a change in pull request #8532:
URL: https://github.com/apache/kafka/pull/8532#discussion_r413110487
##########
File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py
##########
@@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3):
# Start test harness
self.driver = StreamsSmokeTestDriverService(self.test_context, self.kafka)
- self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, num_threads)
+ self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, "at_least_once", num_threads)
Review comment:
Is it enough to specify the processing guarantee as `at_least_once` here or do you want also for this test to include all processing guarantees in the test matrix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on issue #8532:
URL: https://github.com/apache/kafka/pull/8532#issuecomment-618292163
Streams system tests above are green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on a change in pull request #8532:
URL: https://github.com/apache/kafka/pull/8532#discussion_r413116285
##########
File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py
##########
@@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3):
# Start test harness
self.driver = StreamsSmokeTestDriverService(self.test_context, self.kafka)
- self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, num_threads)
+ self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, "at_least_once", num_threads)
Review comment:
On a different note, now that the processing guarantee can be passed to the service, do we still need `StreamsEosTestJobRunnerService` and `StreamsComplexEosTestJobRunnerService`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on issue #8532:
URL: https://github.com/apache/kafka/pull/8532#issuecomment-617883911
Streams system tests run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #8532:
URL: https://github.com/apache/kafka/pull/8532#discussion_r414679179
##########
File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py
##########
@@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3):
# Start test harness
self.driver = StreamsSmokeTestDriverService(self.test_context, self.kafka)
- self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, num_threads)
+ self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, "at_least_once", num_threads)
Review comment:
We can try to add both eos cases, too.
For `Streams[Complex]EosTestJobRunnerService`, they use a different Java class compared to the "smoke test" runner. Not sure if we could unify them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on a change in pull request #8532: HOTFIX: Fix broker bounce system tests
Posted by GitBox <gi...@apache.org>.
abbccdda commented on a change in pull request #8532:
URL: https://github.com/apache/kafka/pull/8532#discussion_r414636938
##########
File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py
##########
@@ -164,7 +164,7 @@ def setup_system(self, start_processor=True, num_threads=3):
# Start test harness
self.driver = StreamsSmokeTestDriverService(self.test_context, self.kafka)
- self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, num_threads)
+ self.processor1 = StreamsSmokeTestJobRunnerService(self.test_context, self.kafka, "at_least_once", num_threads)
Review comment:
I feel neutral about it, if we are adding 2X time to system tests, that's probably not good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests
Posted by GitBox <gi...@apache.org>.
cadonna commented on issue #8532:
URL: https://github.com/apache/kafka/pull/8532#issuecomment-617869532
Call for review: @mjsax @abbccdda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org