You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/17 06:14:53 UTC
[GitHub] [iotdb] ericpai opened a new pull request #4414: [IOTDB-2023] Fix serializing and deserializing bugs of Filters
ericpai opened a new pull request #4414:
URL: https://github.com/apache/iotdb/pull/4414
See JIRA: https://issues.apache.org/jira/browse/IOTDB-2023
The following bugs have been fixed:
1. `GroupByMonthFilter`: It inherits `GroupByMonth` filter but doesn't override `getSerializeId()`, which returns `FilterSerializeId.GROUP_BY` and causes the deserializing instance being `GroupByFilter`.
2. `In`: Not supported in `FilterFactory`.
3. `In`: In the serializing and deserializing method, we should use `ReadWriteUtils.write()` and `ReadWriteUtils.readInt()`. As `buffer.get()` and `stream.write()` handle only 1 byte.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4414: [IOTDB-2023] Fix serializing and deserializing bugs of Filters
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4414:
URL: https://github.com/apache/iotdb/pull/4414#issuecomment-971303617
[](https://coveralls.io/builds/44324704)
Coverage increased (+0.01%) to 66.516% when pulling **ef8377cbc91f40880c4315b10b55c37c3d64c282 on ericpai:bugfix/iotdb-2023** into **dda533dfdc6a676714839fa02ffc011bcd1b04f8 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #4414: [IOTDB-2023] Fix serializing and deserializing bugs of Filters
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #4414:
URL: https://github.com/apache/iotdb/pull/4414#issuecomment-971223534
@JackieTien97 Thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #4414: [IOTDB-2023] Fix serializing and deserializing bugs of Filters
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4414:
URL: https://github.com/apache/iotdb/pull/4414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org