You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/18 07:24:35 UTC

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14084: [Doc] Describe default ack timeout in javadoc

Anonymitaet commented on a change in pull request #14084:
URL: https://github.com/apache/pulsar/pull/14084#discussion_r809733288



##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
##########
@@ -182,7 +182,8 @@
      * 1 second.
      *
      * <p>By default, the acknowledge timeout is disabled and that means that messages delivered to a
-     * consumer will not be re-delivered unless the consumer crashes.
+     * consumer will not be re-delivered unless the consumer crashes. Since 2.3.0, when a dead letter policy

Review comment:
       ```suggestion
        * consumer is not re-delivered unless the consumer crashes. Since 2.3.0, when a dead letter policy
   ```
   Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true.
   https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org