You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by wary <gi...@git.apache.org> on 2017/10/09 15:24:28 UTC
[GitHub] zeppelin pull request #2612: remove the duplicate property username in Remot...
GitHub user wary opened a pull request:
https://github.com/apache/zeppelin/pull/2612
remove the duplicate property username in RemoteInterpreter
### What is this PR for?
* Remove the username property in class RemoteInterpreter, instead reuse the username property in class Interpreter， to avoid get null value with method getUserName in the super class Interpreter
* Overwrite username get/set method in class LazyOpenInterpreter
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* [ZEPPELIN-2981]
### How should this be tested?
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wary/zeppelin RemioteInterpreterUserNameFIx
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2612.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2612
----
commit 4af0253b84fe393e465abdb655501767cbe20e55
Author: lei wang <le...@outlook.com>
Date: 2017-10-09T14:48:00Z
remove the duplicate property username
commit 356101d2033f04cc2430c526e3f236e885c609bb
Author: lei wang <le...@outlook.com>
Date: 2017-10-09T15:15:56Z
fix the username property in LazyOpenInterpreter
----
---
[GitHub] zeppelin issue #2612: remove the duplicate property username in RemoteInterp...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@wary Before I merge this, could you update the title and add '[MINOR]' ?
---
[GitHub] zeppelin issue #2612: remove the duplicate property username in RemoteInterp...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
Thanks @wary Merge it if no more discussion.
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
CI Failure is fixed, please rebase and rerun CI, thanks @wary
---
[GitHub] zeppelin issue #2612: remove the duplicate property username in RemoteInterp...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
LGTM
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by wary <gi...@git.apache.org>.
Github user wary commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@zjffdu done! please help review my another pull request [ZEPPELIN-3021] If you are convenient， thank you very much
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@wary Your PR is mixed with other PR, could you clean it ? Thanks
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by wary <gi...@git.apache.org>.
Github user wary commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@zjffdu done！thx for code review
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by wary <gi...@git.apache.org>.
Github user wary commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@zjffdu all check passed!
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by wary <gi...@git.apache.org>.
Github user wary commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@zjffdu as I checked, the reason of the ci failure is not related to this change， maybe need to create a new pull request to resolve
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by wary <gi...@git.apache.org>.
Github user wary commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@zjffdu done!
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@wary Sorry for late response, the CI seems failed, could you help check that ? It may due to flaky test, you can try to rerun it.
---
[GitHub] zeppelin issue #2612: [MINOR] remove the duplicate property username in Remo...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2612
@wary CI is stuck, could you try again ?
---
[GitHub] zeppelin pull request #2612: [MINOR] remove the duplicate property username ...
Posted by wary <gi...@git.apache.org>.
Github user wary closed the pull request at:
https://github.com/apache/zeppelin/pull/2612
---