You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by jmuehlner <gi...@git.apache.org> on 2016/08/26 05:21:50 UTC
[GitHub] incubator-guacamole-manual pull request #6: GUACAMOLE-87: Bump guacamole-man...
GitHub user jmuehlner opened a pull request:
https://github.com/apache/incubator-guacamole-manual/pull/6
GUACAMOLE-87: Bump guacamole-manual version numbers to 0.9.10-incubating.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmuehlner/incubator-guacamole-manual GUACAMOLE-87-bump-manual-version-numbers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-manual/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit bf47f7cf694114f356c63257281578bc51d63802
Author: James Muehlner <ja...@guac-dev.org>
Date: 2016-08-26T05:21:14Z
GUACAMOLE-87: Bump guacamole-manual version numbers to 0.9.10-incubating.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #6: GUACAMOLE-87: Bump guacamole-man...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/6#discussion_r76366764
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -170,7 +170,7 @@ Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.
script located within the <filename>upgrade/</filename> directory:</para>
<informalexample>
<screen><prompt>$</prompt> <userinput>ls schema/upgrade/</userinput>
-<computeroutput>upgrade-pre-0.8.2.sql upgrade-pre-0.9.7.sql upgrade-pre-0.9.9.sql
+<computeroutput>upgrade-pre-0.8.2.sql upgrade-pre-0.9.7.sql upgrade-pre-0.9.10-incubating.sql
--- End diff --
Also, I believe the upgrade script is `upgrade-pre-0.9.10.sql` (and probably should stay that way for the sake of automation).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #6: GUACAMOLE-87: Bump guacamole-man...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/6#discussion_r76366183
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -201,11 +201,11 @@ upgrade-pre-0.9.6.sql upgrade-pre-0.9.8.sql</computeroutput>
<prompt>Enter password:</prompt> <userinput><replaceable>password</replaceable></userinput>
<prompt>$</prompt></screen>
</informalexample>
- <para>If you are upgrading from a version of Guacamole before 0.9.9, schema changes
+ <para>If you are upgrading from a version of Guacamole before 0.9.10-incubating, schema changes
--- End diff --
Sorry, but we need to add a *new* section for the 0.9.10-incubating upgrade script. Changing the 0.9.9 section to instead point to 0.9.10-incubating makes it wrong. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #6: GUACAMOLE-87: Bump guacamole-man...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-manual/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #6: GUACAMOLE-87: Bump guacamole-man...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/6#discussion_r76366090
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -170,7 +170,7 @@ Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.
script located within the <filename>upgrade/</filename> directory:</para>
<informalexample>
<screen><prompt>$</prompt> <userinput>ls schema/upgrade/</userinput>
-<computeroutput>upgrade-pre-0.8.2.sql upgrade-pre-0.9.7.sql upgrade-pre-0.9.9.sql
+<computeroutput>upgrade-pre-0.8.2.sql upgrade-pre-0.9.7.sql upgrade-pre-0.9.10-incubating.sql
--- End diff --
Why do you hate the pre 0.9.9 upgrade script?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---