[GitHub] [spark] vanzin commented on issue #24142: [SPARK-27194][core] Job failures when task attempts do not clean up spark-staging parquet files

[GitBox <gi...@apache.org>]

vanzin commented on issue #24142: [SPARK-27194][core] Job failures when task attempts do not clean up spark-staging parquet files
URL: https://github.com/apache/spark/pull/24142#issuecomment-474603317
 
 
   Without looking (again) into this code I have the same question about this potentially causing duplicates in the case an executor fails.
   
   > Isn't it better to call datawriter.abort() before raising the exception here:
   
   No, because the executor may die before calling that, and the code needs to be resilient to that. (Also, as far as I can tell, that's already being done in the call to `tryWithSafeFinallyAndFailureCallbacks`.)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org