You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by yukon <yu...@apache.org> on 2017/02/07 09:36:27 UTC
[RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Hello RocketMQ Community,
This is the vote for 4.0.0 of Apache RocketMQ (incubating).
The artifacts:
https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.0.0-incubating/
Git tag for the release:
https://github.com/apache/incubator-rocketmq/tree/rocketmq-4.0.0-incubating
Hash for the release tag:
ae0eeba846ec2157c012469ecc540abf60aed007
Release Notes:
http://rocketmq.incubator.apache.org/release_notes/release-notes-4.0.0-incubating/
The artifacts have been signed with Key : C50AC1B1, which can be found in
the keys file:
https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
The maven release artifacts:
https://repository.apache.org/content/repositories/orgapacherocketmq-1001
The vote will be open for at least 72 hours or until necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache RocketMQ Team
Re: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Willem Jiang <wi...@gmail.com>.
-1.
Please address the below issues before starting a new vote.
1. README.md in the source and binary files has some enhanced feature
descriptions all lead to Alibaba ONS. We could just provide a commercial
support page in the RocketMQ web site.
2. README.md in the bin directory of binaray has the description of
windows exe which doesn't exit. My suggestion is remove the description.
3. The signed KEY need to be 2048 bit.
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Tue, Feb 7, 2017 at 5:36 PM, yukon <yu...@apache.org> wrote:
> Hello RocketMQ Community,
>
> This is the vote for 4.0.0 of Apache RocketMQ (incubating).
>
> The artifacts:
> https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.
> 0.0-incubating/
>
> Git tag for the release:
> https://github.com/apache/incubator-rocketmq/tree/
> rocketmq-4.0.0-incubating
>
> Hash for the release tag:
> ae0eeba846ec2157c012469ecc540abf60aed007
>
> Release Notes:
> http://rocketmq.incubator.apache.org/release_notes/release-notes-4.0.0-
> incubating/
>
> The artifacts have been signed with Key : C50AC1B1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
>
> The maven release artifacts:
> https://repository.apache.org/content/repositories/orgapacherocketmq-1001
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache RocketMQ Team
>
RE:[RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Posted by dongeforever <10...@qq.com>.
Hi,
+1
I checked:
- incubating in name
- signature and hashes fine
- DISCLAIMER exists
- LICENSEs OK
- NOTICE OK
- All ASF files have headers
- No unexpected binary files
- Can compile from source
It looks good except a minor issue, and I have fixed it at:
https://github.com/apache/incubator-rocketmq/pull/54
Thanks,
dongeforever
------------------ 原始邮件 ------------------
发件人: "yukon";<yu...@apache.org>;
发送时间: 2017年2月7日(星期二) 下午5:36
收件人: "dev"<de...@rocketmq.incubator.apache.org>;
主题: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Hello RocketMQ Community,
This is the vote for 4.0.0 of Apache RocketMQ (incubating).
The artifacts:
https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.0.0-incubating/
Git tag for the release:
https://github.com/apache/incubator-rocketmq/tree/rocketmq-4.0.0-incubating
Hash for the release tag:
ae0eeba846ec2157c012469ecc540abf60aed007
Release Notes:
http://rocketmq.incubator.apache.org/release_notes/release-notes-4.0.0-incubating/
The artifacts have been signed with Key : C50AC1B1, which can be found in
the keys file:
https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
The maven release artifacts:
https://repository.apache.org/content/repositories/orgapacherocketmq-1001
The vote will be open for at least 72 hours or until necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache RocketMQ Team
Re: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Thanks for your careful check, all the issues you mentioned will be
> resolved in next release, below are the related JIRA issues
Always good to have JIRAs raised for release issues, the IPMC may ask for them / vote differently if they are there.
> BTW, I checked that rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
> doesn't exist in the release which may be generated by JVM.
My mistake I must of unzipped over the previous RC. It’s a good idea to name the files with the RC number in them (stops this and caching issues), you may want to consider that for the next release.
Thanks,
Justin
Re: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Posted by yukon <yu...@apache.org>.
Hi Justin,
Thanks for your careful check, all the issues you mentioned will be
resolved in next release, below are the related JIRA issues:
1. https://issues.apache.org/jira/browse/ROCKETMQ-85
2. https://issues.apache.org/jira/browse/ROCKETMQ-86
3. https://issues.apache.org/jira/browse/ROCKETMQ-87
4. https://issues.apache.org/jira/browse/ROCKETMQ-88
BTW, I checked that rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
doesn't exist in the release which may be generated by JVM.
Regards,
yukon
On Wed, Feb 8, 2017 at 12:31 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> +1 binding
>
> The source release has a few minor issue that can be fixed next time. The
> binary release does need some work in it’s LICENSE and NOTICE.
>
> I checked:
> - incubating in file names
> - hashes and signatures good
> - DISCLAIMER exists
> - LICENSE and NOTICE good
> - All source files have ASF headers
> - No unexpected binary files
> - Can compile from source
>
> Nice work!
>
> This file [1] is still in the release and was brought up as an issue for
> last release candidate. Do we want to release with this error file in the
> source? Even if the votes passes up to the release manager to consider.
>
> The README still has some issues I think, but lets fix them up after this
> release. We want to make sure that the first point of contact for
> developers and users are these mailing lists / incubating site and there no
> prominent 3rd party links in there.
>
> Some very minor things to consider changing:
> - BUIDLING refers to tar.gz packages but the source package is a zip
> - CONTRIBUTING section “Becoming a committer” and "important contribution
> points” needs a little work IMO
> - The pom lists a number of developers and GitHub links, this is unusual
> for an Apache project.
>
> The binary the LICENSE and NOTICE will need some more work as it bundles
> a number of things that are not from the ASF, having multiple license or
> are Apache licensed. See [2] (notice that affects ours), [3] (not ASF
> apache software), [4] (multiple licenses), [5] (multiple licenses), [6]
> (non Apache license), [7] (non Apache license), [8] (notice file)., [9]
> (non Apache license).
>
> Thanks,
> Justin
>
> 1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
> 2. https://github.com/apache/commons-lang/blob/master/NOTICE.txt
> 3. https://github.com/alibaba/fastjson
> 4. https://github.com/jboss-javassist/javassist/blob/master/License.html
> 5. https://github.com/java-native-access/jna
> 6. https://mvnrepository.com/artifact/ch.qos.logback/logback-classic
> 7. https://mvnrepository.com/artifact/ch.qos.logback/logback-core
> 8. https://github.com/netty/netty/blob/4.1/NOTICE.txt
> 9. https://www.slf4j.org/license.html
Re: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 binding
The source release has a few minor issue that can be fixed next time. The binary release does need some work in it’s LICENSE and NOTICE.
I checked:
- incubating in file names
- hashes and signatures good
- DISCLAIMER exists
- LICENSE and NOTICE good
- All source files have ASF headers
- No unexpected binary files
- Can compile from source
Nice work!
This file [1] is still in the release and was brought up as an issue for last release candidate. Do we want to release with this error file in the source? Even if the votes passes up to the release manager to consider.
The README still has some issues I think, but lets fix them up after this release. We want to make sure that the first point of contact for developers and users are these mailing lists / incubating site and there no prominent 3rd party links in there.
Some very minor things to consider changing:
- BUIDLING refers to tar.gz packages but the source package is a zip
- CONTRIBUTING section “Becoming a committer” and "important contribution points” needs a little work IMO
- The pom lists a number of developers and GitHub links, this is unusual for an Apache project.
The binary the LICENSE and NOTICE will need some more work as it bundles a number of things that are not from the ASF, having multiple license or are Apache licensed. See [2] (notice that affects ours), [3] (not ASF apache software), [4] (multiple licenses), [5] (multiple licenses), [6] (non Apache license), [7] (non Apache license), [8] (notice file)., [9] (non Apache license).
Thanks,
Justin
1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
2. https://github.com/apache/commons-lang/blob/master/NOTICE.txt
3. https://github.com/alibaba/fastjson
4. https://github.com/jboss-javassist/javassist/blob/master/License.html
5. https://github.com/java-native-access/jna
6. https://mvnrepository.com/artifact/ch.qos.logback/logback-classic
7. https://mvnrepository.com/artifact/ch.qos.logback/logback-core
8. https://github.com/netty/netty/blob/4.1/NOTICE.txt
9. https://www.slf4j.org/license.html
Re: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Posted by lollipop <lo...@apache.org>.
+1
So far I've successfully checked:
- names include incubating
- no binaries found at the source distribution
- clean build
- signatures and hashes
- run Quick Start successfully according to the User Guide[1].
[1]. http://rocketmq.incubator.apache.org/docs/quick-start/
Thanks,
Lollipop
On Tue, Feb 7, 2017 at 5:36 PM, yukon <yu...@apache.org> wrote:
> Hello RocketMQ Community,
>
> This is the vote for 4.0.0 of Apache RocketMQ (incubating).
>
> The artifacts:
> https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.
> 0.0-incubating/
>
> Git tag for the release:
> https://github.com/apache/incubator-rocketmq/tree/
> rocketmq-4.0.0-incubating
>
> Hash for the release tag:
> ae0eeba846ec2157c012469ecc540abf60aed007
>
> Release Notes:
> http://rocketmq.incubator.apache.org/release_notes/release-notes-4.0.0-
> incubating/
>
> The artifacts have been signed with Key : C50AC1B1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
>
> The maven release artifacts:
> https://repository.apache.org/content/repositories/orgapacherocketmq-1001
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache RocketMQ Team
>
Re: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Willem Jiang <wi...@gmail.com>.
Hi zixu,
Please spend some time to check the artifacts instead of just +1.
If you are a user, please run the broker service with your application to
check if it works as you expected.
If you are a developer, you may need to build the artifacts with the source.
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Tue, Feb 7, 2017 at 5:37 PM, zixu mo <hu...@gmail.com> wrote:
>
>
> +1 approve
>
>
>
>
>
>
> On Tue, Feb 7, 2017 at 5:36 PM +0800, "yukon" <yu...@apache.org> wrote:
>
>
>
>
>
>
>
>
>
>
> Hello RocketMQ Community,
>
> This is the vote for 4.0.0 of Apache RocketMQ (incubating).
>
> The artifacts:
> https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.
> 0.0-incubating/
>
> Git tag for the release:
> https://github.com/apache/incubator-rocketmq/tree/
> rocketmq-4.0.0-incubating
>
> Hash for the release tag:
> ae0eeba846ec2157c012469ecc540abf60aed007
>
> Release Notes:
> http://rocketmq.incubator.apache.org/release_notes/release-notes-4.0.0-
> incubating/
>
> The artifacts have been signed with Key : C50AC1B1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
>
> The maven release artifacts:
> https://repository.apache.org/content/repositories/orgapacherocketmq-1001
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache RocketMQ Team
>
>
>
>
>
>
Re: [RESTART][VOTE]: Release Apache RocketMQ 4.0.0(incubating)
Posted by zixu mo <hu...@gmail.com>.
+1 approve
On Tue, Feb 7, 2017 at 5:36 PM +0800, "yukon" <yu...@apache.org> wrote:
Hello RocketMQ Community,
This is the vote for 4.0.0 of Apache RocketMQ (incubating).
The artifacts:
https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.0.0-incubating/
Git tag for the release:
https://github.com/apache/incubator-rocketmq/tree/rocketmq-4.0.0-incubating
Hash for the release tag:
ae0eeba846ec2157c012469ecc540abf60aed007
Release Notes:
http://rocketmq.incubator.apache.org/release_notes/release-notes-4.0.0-incubating/
The artifacts have been signed with Key : C50AC1B1, which can be found in
the keys file:
https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
The maven release artifacts:
https://repository.apache.org/content/repositories/orgapacherocketmq-1001
The vote will be open for at least 72 hours or until necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache RocketMQ Team