[GitHub] [airflow] joeyfreund commented on a change in pull request #7400: [AIRFLOW-6759] Added MLEngine operator/hook to cancel MLEngine jobs

[GitBox <gi...@apache.org>]

joeyfreund commented on a change in pull request #7400: [AIRFLOW-6759] Added MLEngine operator/hook to cancel MLEngine jobs
URL: https://github.com/apache/airflow/pull/7400#discussion_r377742121
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/mlengine.py
 ##########
 @@ -148,6 +148,51 @@ def create_job(
 
         return self._wait_for_job_done(project_id, job_id)
 
+    @CloudBaseHook.fallback_to_default_project_id
+    def cancel_job(
+        self,
+        job_id,
+        project_id: Optional[str] = None
+    ) -> Dict:
+
+        """
+        Cancels a MLEngine job.
+
+        :param project_id: The Google Cloud project id within which MLEngine
+            job will be launched. If set to None or missing, the default project_id from the GCP
 
 Review comment:
   This comment (describing the behaviour when `project_id` is `None`) is inconsistent with the code below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services