You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/08/05 23:21:20 UTC

Review Request 13304: [OOZIE-1388] Add a admin servlet to show thread stack trace and CPU usage per thread

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13304/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1388
    https://issues.apache.org/jira/browse/OOZIE-1388


Repository: oozie


Description
-------

Page that shows jvm information like memory and thread stacks 


Diffs
-----

  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java PRE-CREATION 
  http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/WEB-INF/web-common.xml 1510726 
  http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/admin/jvminfo.jsp PRE-CREATION 

Diff: https://reviews.apache.org/r/13304/diff/


Testing
-------

Manually tested since it is a UI page


Thanks,

Rohini Palaniswamy


Re: Review Request 13304: [OOZIE-1388] Add a admin servlet to show thread stack trace and CPU usage per thread

Posted by Rohini Palaniswamy <ro...@gmail.com>.

> On Sept. 13, 2013, 12:33 a.m., Mona Chitnis wrote:
> > Please attach a screenshot of this UI when run on your machine to get an idea. Also add documentation in the Admin section of twiki for usage

Will do. 


> On Sept. 13, 2013, 12:33 a.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java, line 44
> > <https://reviews.apache.org/r/13304/diff/1/?file=337299#file337299line44>
> >
> >     What would the values passed to 'threadSortOrder'?

cpu (cpu usage), name (name of the thread). default sorting is by the status (RUNNABLE, WAITING, etc) 


> On Sept. 13, 2013, 12:33 a.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java, line 92
> > <https://reviews.apache.org/r/13304/diff/1/?file=337299#file337299line92>
> >
> >     What is the meaning of 'committed' here?

http://www.docjar.com/docs/api/java/lang/management/MemoryUsage.html


- Rohini


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13304/#review26069
-----------------------------------------------------------


On Aug. 5, 2013, 9:21 p.m., Rohini Palaniswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13304/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 9:21 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1388
>     https://issues.apache.org/jira/browse/OOZIE-1388
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> Page that shows jvm information like memory and thread stacks 
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/WEB-INF/web-common.xml 1510726 
>   http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/admin/jvminfo.jsp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13304/diff/
> 
> 
> Testing
> -------
> 
> Manually tested since it is a UI page
> 
> 
> Thanks,
> 
> Rohini Palaniswamy
> 
>


Re: Review Request 13304: [OOZIE-1388] Add a admin servlet to show thread stack trace and CPU usage per thread

Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13304/#review26069
-----------------------------------------------------------


Please attach a screenshot of this UI when run on your machine to get an idea. Also add documentation in the Admin section of twiki for usage


http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java
<https://reviews.apache.org/r/13304/#comment50899>

    What would the values passed to 'threadSortOrder'?



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java
<https://reviews.apache.org/r/13304/#comment50897>

    What is the meaning of 'committed' here?


- Mona Chitnis


On Aug. 5, 2013, 9:21 p.m., Rohini Palaniswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13304/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 9:21 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1388
>     https://issues.apache.org/jira/browse/OOZIE-1388
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> Page that shows jvm information like memory and thread stacks 
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/JVMInfo.java PRE-CREATION 
>   http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/WEB-INF/web-common.xml 1510726 
>   http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/admin/jvminfo.jsp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13304/diff/
> 
> 
> Testing
> -------
> 
> Manually tested since it is a UI page
> 
> 
> Thanks,
> 
> Rohini Palaniswamy
> 
>