[GitHub] spark pull request #17185: [SPARK-19602][SQL] Support column resolution of f...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17185#discussion_r163322810
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ---
    @@ -88,12 +88,12 @@ case class UnresolvedAttribute(nameParts: Seq[String]) extends Attribute with Un
       override def exprId: ExprId = throw new UnresolvedException(this, "exprId")
       override def dataType: DataType = throw new UnresolvedException(this, "dataType")
       override def nullable: Boolean = throw new UnresolvedException(this, "nullable")
    -  override def qualifier: Option[String] = throw new UnresolvedException(this, "qualifier")
    +  override def qualifier: Option[Seq[String]] = throw new UnresolvedException(this, "qualifier")
    --- End diff --
    
    I think we can just use `Seq[String]`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org