You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/09 11:43:11 UTC
[GitHub] [incubator-tvm] cbalint13 opened a new pull request #6431: Address issue #6415 using compiler-rt half-float function.
cbalint13 opened a new pull request #6431:
URL: https://github.com/apache/incubator-tvm/pull/6431
Address issue #6415 as disscussed in PR #6416 opened by @tom-gall .
* Proposed fix comes by @tqchen https://github.com/apache/incubator-tvm/pull/6416#issuecomment-688527472
-----
@junrushao1994 , @u99127 , @tqchen please help with the review.
Thank You !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6431: Address issue #6415 using compiler-rt half-float function.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6431:
URL: https://github.com/apache/incubator-tvm/pull/6431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6431: Address issue #6415 using compiler-rt half-float function.
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6431:
URL: https://github.com/apache/incubator-tvm/pull/6431#discussion_r485779432
##########
File path: src/relay/transforms/pattern_util.h
##########
@@ -398,7 +398,8 @@ static inline long double ToScalar(const runtime::NDArray& array, size_t i = 0)
} else if (array->dtype.code == kDLFloat) {
#if (__ARM_FP16_FORMAT_IEEE == 1)
Review comment:
perhaps we no longer need this macro guard anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] cbalint13 commented on a change in pull request #6431: Address issue #6415 using compiler-rt half-float function.
Posted by GitBox <gi...@apache.org>.
cbalint13 commented on a change in pull request #6431:
URL: https://github.com/apache/incubator-tvm/pull/6431#discussion_r485783944
##########
File path: src/relay/transforms/pattern_util.h
##########
@@ -398,7 +398,8 @@ static inline long double ToScalar(const runtime::NDArray& array, size_t i = 0)
} else if (array->dtype.code == kDLFloat) {
#if (__ARM_FP16_FORMAT_IEEE == 1)
Review comment:
Right, removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org