[GitHub] [druid] coryverta commented on a diff in pull request #13175: upgrade kubernetes extension k8s client api jar to v16

[GitBox <gi...@apache.org>]

coryverta commented on code in PR #13175:
URL: https://github.com/apache/druid/pull/13175#discussion_r989455945


##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/K8sDiscoveryModule.java:
##########
@@ -63,7 +64,10 @@ public void configure(Binder binder)
                 try {
                   // Note: we can probably improve things here about figuring out how to find the K8S API server,
                   // HTTP client timeouts etc.
-                  return Config.defaultClient();
+                  final SimpleDateFormat dateFormat = new SimpleDateFormat(
+                      "yyyyMMdd'T'HHmmss.SSS'Z'");
+                  dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));

Review Comment:
   I need to confirm that this _always_ originates in K8s, and is always consistent.  It is likely better to allow this format string to be configured by the user, but to default the most common format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org