You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/09/03 21:17:49 UTC

[GitHub] [helix] micahstubbs opened a new pull request, #2204: 2203/helix front storybook visual tests

micahstubbs opened a new pull request, #2204:
URL: https://github.com/apache/helix/pull/2204

   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   
   #2203 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR sets up visual tests with [Storybook](https://storybook.js.org/docs/angular/get-started/introduction) for helix-front.
   
   ![Screen Shot 2022-09-03 at 2 13 05 PM](https://user-images.githubusercontent.com/2119400/188287955-a95c5496-1143-4764-8591-4284a5058909.png)
   ![Screen Shot 2022-09-03 at 2 13 00 PM](https://user-images.githubusercontent.com/2119400/188287956-bef3addd-52d0-4b10-9c64-5df6e95abd28.png)
   ![Screen Shot 2022-09-03 at 2 12 56 PM](https://user-images.githubusercontent.com/2119400/188287958-51fc2ac6-a1cf-4013-859b-1282bea24a79.png)
   
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   [src/app/shared/state-label/state-label.stories.ts](src/app/shared/state-label/state-label.stories.ts)
   
   ### Code Quality
   
   - [x] My diff has been formatted using [Prettier](https://prettier.io/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] micahstubbs commented on pull request #2204: 2203/helix front storybook visual tests

Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2204:
URL: https://github.com/apache/helix/pull/2204#issuecomment-1238480197

   @somecodemonkey this is ready for a review. Thanks for sharing your frontend expertise!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] NealSun96 merged pull request #2204: 2203/helix front storybook visual tests

Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2204:
URL: https://github.com/apache/helix/pull/2204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] micahstubbs commented on pull request #2204: 2203/helix front storybook visual tests

Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2204:
URL: https://github.com/apache/helix/pull/2204#issuecomment-1238611659

   This PR is ready to be merged, approved by @somecodemonkey 
        
   Final commit message:
   ## Helix Front storybook visual tests (#2203)
   Add visual tests and config for helix-front.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] micahstubbs commented on pull request #2204: 2203/helix front storybook visual tests

Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2204:
URL: https://github.com/apache/helix/pull/2204#issuecomment-1238479734

   Test failure seems to be a Helix Controller backend error unrelated to these frontend changes. https://github.com/apache/helix/runs/8172150968?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] somecodemonkey commented on pull request #2204: 2203/helix front storybook visual tests

Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on PR #2204:
URL: https://github.com/apache/helix/pull/2204#issuecomment-1238529887

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] micahstubbs commented on a diff in pull request #2204: 2203/helix front storybook visual tests

Posted by GitBox <gi...@apache.org>.
micahstubbs commented on code in PR #2204:
URL: https://github.com/apache/helix/pull/2204#discussion_r964017100


##########
helix-front/angular.json:
##########
@@ -5,28 +5,28 @@
   "projects": {
     "helix-front": {
       "root": "",
-      "sourceRoot": "client",
+      "sourceRoot": "src",

Review Comment:
   The majority of the diff is related to this change, which was required by storybook.
   
   Error message:
   
   ```bash
   The client/assets asset path must start with the project source root.
   ```
   
   https://github.com/apache/helix/issues/2203#issuecomment-1236168591
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org