You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/15 13:23:58 UTC

[GitHub] [flink] godfreyhe opened a new pull request #9119: [FLINK-13268] [table-planner-blink] Revert SqlSplittableAggFunction to support making two planners available in one jar

godfreyhe opened a new pull request #9119: [FLINK-13268] [table-planner-blink] Revert SqlSplittableAggFunction to support making two planners available in one jar
URL: https://github.com/apache/flink/pull/9119
 
 
   
   
   ## What is the purpose of the change
   
   *Revert SqlSplittableAggFunction to support making two planners available in one jar*
   
   
   ## Brief change log
   
     - *remove SqlSplittableAggFunction*
     - *remove related-code in FlinkAggregateJoinTransposeRule*
     - *remove related test*
   
   
   ## Verifying this change
   
   all existing tests should pass, except some cases's result should be updated. Because the behavior of SqlSplittableAggFunction is changed, and no `cast` in the result of FlinkAggregateJoinTransposeRule. which will effect the cost of FlinkLogicalCalc (see: CommonCalc#computeSelfCost)
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services