You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/06/15 21:48:20 UTC

[GitHub] cordova-windows pull request #178: CB-11443 Splashscreen is created the seco...

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/178

    CB-11443 Splashscreen is created the second time on resume on Windows

    Jira issue: https://issues.apache.org/jira/browse/CB-11443
    
    Looks like github repo is out of sync with Apache.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-11443

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 04a2904233e48b14d7158f2014487253f1a4116f
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2016-05-31T06:38:36Z

    CB-11334 Merge changes from 4.4.x release branch into master
    
    This includes
    CB-11334 Reorganize node_modules back to hierarchy tree
    CB-11334 Update RELEASENOTES

commit 67f962156df3c373d55cbe7f04546b1ea2a8db83
Author: daserge <v-...@microsoft.com>
Date:   2016-06-15T21:32:11Z

    CB-11443 Splashscreen is created the second time on resume on Windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request #178: CB-11443 Splashscreen is created the seco...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-windows/pull/178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows issue #178: CB-11443 Splashscreen is created the second time...

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-windows/pull/178
  
    ## [Current coverage][cc-pull] is **72.17%**
    > Merging [#178][cc-pull] into [master][cc-base-branch] will not change coverage
    
    ```diff
    @@             master       #178   diff @@
    ==========================================
      Files            14         14          
      Lines          1905       1905          
      Methods         351        351          
      Messages          0          0          
      Branches        385        385          
    ==========================================
      Hits           1375       1375          
      Misses          530        530          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d7f4b84...67f9621][cc-compare]
    [cc-base-branch]: https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
    [cc-compare]: https://codecov.io/gh/apache/cordova-windows/compare/d7f4b842d1d3109652192af5de01cfbe69a09e2a...67f962156df3c373d55cbe7f04546b1ea2a8db83
    [cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/178?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows issue #178: CB-11443 Splashscreen is created the second time...

Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:

    https://github.com/apache/cordova-windows/pull/178
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org