You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/12 13:38:09 UTC
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3561: ARTEMIS-3258 added warning for url parameters that are explicitly ignored
brusdev commented on a change in pull request #3561:
URL: https://github.com/apache/activemq-artemis/pull/3561#discussion_r631049117
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/config/federation/FederationDownstreamConfiguration.java
##########
@@ -40,23 +41,30 @@ public TransportConfiguration getUpstreamConfiguration() {
return upstreamConfiguration;
}
+ private void stripParam(Map<String, Object> params, String name) {
+ Object oldValue = params.remove(name);
+ if (oldValue != null) {
+ ActiveMQClientLogger.LOGGER.ignoredParameterForDownstreamFederation(name);
+ }
Review comment:
there are 8 checkstyle violations because lines 45-48 contain tab characters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org