You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2010/10/12 12:14:35 UTC
[jira] Created: (JCR-2778) Node.removeMixin fails if the mixin
defines a protected child node
Node.removeMixin fails if the mixin defines a protected child node
------------------------------------------------------------------
Key: JCR-2778
URL: https://issues.apache.org/jira/browse/JCR-2778
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-core
Reporter: angela
Assignee: angela
Fix For: 2.2.0
Node.removeMixin fails if the mixin to removed defines a protected child node.... the problem is caused by line 253 of RemoveMixinOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2778) Node.removeMixin fails if the mixin
defines a protected child node
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920555#action_12920555 ]
Jukka Zitting commented on JCR-2778:
------------------------------------
> FWIW: this issue is a regression of JCR-890, i.e. the refactoring involved (r982520).
I don't recall making any functional changes when refactoring this code (I explicitly tried to avoid regressions), but it may be that I missed something. AFAICT the entire loop around line 253 of RemoveMixinOperation is identical to the one in NodeImpl.removeMixin() before revision 982520. Where's the regression?
> Node.removeMixin fails if the mixin defines a protected child node
> ------------------------------------------------------------------
>
> Key: JCR-2778
> URL: https://issues.apache.org/jira/browse/JCR-2778
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: angela
> Assignee: angela
> Fix For: 2.2.0
>
>
> Node.removeMixin fails if the mixin to removed defines a protected child node.... the problem is caused by line 253 of RemoveMixinOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2778) Node.removeMixin fails if the mixin
defines a protected child node
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920493#action_12920493 ]
Stefan Guggisberg commented on JCR-2778:
----------------------------------------
FWIW: this issue is a regression of JCR-890, i.e. the refactoring involved (r982520).
there might be more hidden issues like this.
> Node.removeMixin fails if the mixin defines a protected child node
> ------------------------------------------------------------------
>
> Key: JCR-2778
> URL: https://issues.apache.org/jira/browse/JCR-2778
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: angela
> Assignee: angela
> Fix For: 2.2.0
>
>
> Node.removeMixin fails if the mixin to removed defines a protected child node.... the problem is caused by line 253 of RemoveMixinOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-2778) Node.removeMixin fails if the mixin
defines a protected child node
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-2778.
-------------------------
Resolution: Fixed
> Node.removeMixin fails if the mixin defines a protected child node
> ------------------------------------------------------------------
>
> Key: JCR-2778
> URL: https://issues.apache.org/jira/browse/JCR-2778
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: angela
> Assignee: angela
> Fix For: 2.2.0
>
>
> Node.removeMixin fails if the mixin to removed defines a protected child node.... the problem is caused by line 253 of RemoveMixinOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-2778) Node.removeMixin fails if the mixin
defines a protected child node
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920564#action_12920564 ]
Jukka Zitting commented on JCR-2778:
------------------------------------
Ah, nevermind, I see that Angela already fixed this. I'd changed the name of the childNode variable to node, which shadowed the similarly named variable from the surrounding scope. Sorry about that. :-(
> Node.removeMixin fails if the mixin defines a protected child node
> ------------------------------------------------------------------
>
> Key: JCR-2778
> URL: https://issues.apache.org/jira/browse/JCR-2778
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Reporter: angela
> Assignee: angela
> Fix For: 2.2.0
>
>
> Node.removeMixin fails if the mixin to removed defines a protected child node.... the problem is caused by line 253 of RemoveMixinOperation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.