[GitHub] [arrow-datafusion] metesynnada commented on pull request #5937: Streaming Memory Reservation in SHJ

["metesynnada (via GitHub)" <gi...@apache.org>]

metesynnada commented on PR #5937:
URL: https://github.com/apache/arrow-datafusion/pull/5937#issuecomment-1505072179

   > Makes sense to me -- thank you @metesynnada
   > 
   > I suggest an "integration" test that shows that this code is all hooked up correctly -- perhaps in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/memory_limit.rs
   
   Currently, testing of memory limit SHJ is blocked as I need to implement a `PartitionMode` selection and enable `with_repartition_joins` to remove `RepartitionExec`'s from the planner based on the configuration. Once this is done, I will add the required test in a future PR. As a result, I am unable to test `SHJ` within a query at the moment. Would that be acceptable?
   
   Or, I can build `ExecutionPlan` without a query, which is different than other tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org