[trafficserver] branch master updated: coverity 1021720, 1021721, 1254795, 1021722: ESI plugin

[vm...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

vmamidi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  df81e81   coverity 1021720,1021721,1254795,1021722: ESI plugin
df81e81 is described below

commit df81e814ce1a48157c77106d215ac1bb6807e703
Author: Vijay Mamidi <vi...@yahoo.com>
AuthorDate: Wed May 10 18:03:57 2017 -0400

    coverity 1021720,1021721,1254795,1021722: ESI plugin
---
 plugins/esi/esi.cc           | 4 ++--
 plugins/esi/lib/EsiGunzip.cc | 3 +++
 plugins/esi/lib/EsiGzip.cc   | 3 +++
 plugins/esi/lib/EsiParser.h  | 2 +-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/plugins/esi/esi.cc b/plugins/esi/esi.cc
index 47c8ff7..ce085c2 100644
--- a/plugins/esi/esi.cc
+++ b/plugins/esi/esi.cc
@@ -97,7 +97,7 @@ struct ContData {
   };
   STATE curr_state;
   TSVIO input_vio;
-  TSIOBufferReader input_reader;
+  TSIOBufferReader input_reader = nullptr;
   TSVIO output_vio;
   TSIOBuffer output_buffer;
   TSIOBufferReader output_reader;
@@ -108,7 +108,7 @@ struct ContData {
   EsiGunzip *esi_gunzip;
   TSCont contp;
   TSHttpTxn txnp;
-  const struct OptionInfo *option_info;
+  const struct OptionInfo *option_info = nullptr;
   char *request_url;
   sockaddr const *client_addr;
   DataType input_type;
diff --git a/plugins/esi/lib/EsiGunzip.cc b/plugins/esi/lib/EsiGunzip.cc
index a11648c..26bbea9 100644
--- a/plugins/esi/lib/EsiGunzip.cc
+++ b/plugins/esi/lib/EsiGunzip.cc
@@ -34,6 +34,9 @@ EsiGunzip::EsiGunzip(const char *debug_tag, ComponentBase::Debug debug_func, Com
 {
   _init    = false;
   _success = true;
+  // zlib _zstrm varibles are initialzied when they are required in stream_decode
+  // coverity[uninit_member]
+  // coverity[uninit_ctor]
 }
 
 bool
diff --git a/plugins/esi/lib/EsiGzip.cc b/plugins/esi/lib/EsiGzip.cc
index 35d2ff8..6c0c7cf 100644
--- a/plugins/esi/lib/EsiGzip.cc
+++ b/plugins/esi/lib/EsiGzip.cc
@@ -32,6 +32,9 @@ using namespace EsiLib;
 EsiGzip::EsiGzip(const char *debug_tag, ComponentBase::Debug debug_func, ComponentBase::Error error_func)
   : ComponentBase(debug_tag, debug_func, error_func), _downstream_length(0), _total_data_length(0)
 {
+  // Zlib _zstrm varibles are initialized when they are required in runDeflateLoop
+  // coverity[uninit_member]
+  // coverity[uninit_ctor]
 }
 
 template <typename T>
diff --git a/plugins/esi/lib/EsiParser.h b/plugins/esi/lib/EsiParser.h
index 45c5f1a..fb55ead 100644
--- a/plugins/esi/lib/EsiParser.h
+++ b/plugins/esi/lib/EsiParser.h
@@ -94,7 +94,7 @@ private:
 
   std::string _data;
   int _parse_start_pos;
-  size_t _orig_output_list_size;
+  size_t _orig_output_list_size = 0;
 
   static const EsiNodeInfo ESI_NODES[];
   static const EsiNodeInfo HTML_COMMENT_NODE_INFO;

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].