[jira] [Comment Edited] (FLINK-15156) Warn user if System.exit() is called in user code

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178982#comment-17178982 ] 

Chesnay Schepler edited comment on FLINK-15156 at 8/17/20, 1:42 PM:
--------------------------------------------------------------------

[~twbraam] I think it would be fine if you'd just throw an exception in your catch block; the offending task will fail, while others can continue running.

Note that for addressing the issue that [~rmetzger] referenced you have to adjust the {{Jar(Plan|Run)Handler}}.

Not sure whether we would want to guard all places where user-code is involved, but it may make sense?

 


was (Author: zentol):
[~twbraam] I think it would be fine if you'd just throw an exception in your catch block; the offending task will fail, while others can continue running.

Note that for addressing the issue that [~rmetzger] referenced you have to adjust the \{{Jar(Plan|Run)Handler}}.

Note that whether we would want to guard all places where user-code is involved, but it may make sense?

 

> Warn user if System.exit() is called in user code
> -------------------------------------------------
>
>                 Key: FLINK-15156
>                 URL: https://issues.apache.org/jira/browse/FLINK-15156
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>            Reporter: Robert Metzger
>            Priority: Minor
>              Labels: starter
>
> It would make debugging Flink errors easier if we would intercept and log calls to System.exit() through the SecurityManager.
> A user recently had an error where the JobManager was shutting down because of a System.exit() in the user code: https://lists.apache.org/thread.html/b28dabcf3068d489f38399c456c80d48569fcdf74b15f8bb95d532d0%40%3Cuser.flink.apache.org%3E
> If I remember correctly, we had such issues before.
> I put this ticket into the "Runtime / Coordination" component, as it is mostly about improving the usability / debuggability in that area.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)