You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@inlong.apache.org by GitBox <gi...@apache.org> on 2021/07/28 11:17:26 UTC
[GitHub] [incubator-inlong] dockerzhang opened a new issue #665: [INLONG-66] TubeSingleSessionFactory shutdown bug
dockerzhang opened a new issue #665:
URL: https://github.com/apache/incubator-inlong/issues/665
<p>1. TubeSingleSessionFactory could not shutdown<br/>
due to we increase referenceCounter one more time after first constructor method:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">
<span class="code-keyword">public</span> TubeSingleSessionFactory(<span class="code-keyword">final</span> TubeClientConfig tubeClientConfig) <span class="code-keyword">throws</span> TubeClientException {
<span class="code-keyword">if</span> (referenceCounter.incrementAndGet() == 1) {
RpcConfig config = TubeClientConfigUtils.getRpcConfigByClientConfig(tubeClientConfig, <span class="code-keyword">true</span>);
clientFactory.configure(config);
<span class="code-comment">//#1
</span>referenceCounter.incrementAndGet();
baseSessionFactory = <span class="code-keyword">new</span> TubeBaseSessionFactory(clientFactory, tubeClientConfig);
}
}
</pre>
</div></div>
<p>We should remove #1</p>
<i>JIRA link - <a href="https://issues.apache.org/jira/browse/INLONG-66">[INLONG-66]</a> created by technoboy</i>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang closed issue #665: [INLONG-66] TubeSingleSessionFactory shutdown bug
Posted by GitBox <gi...@apache.org>.
dockerzhang closed issue #665:
URL: https://github.com/apache/incubator-inlong/issues/665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org